Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init with hsv formant bug #22

Open
bulat-f opened this issue Oct 7, 2015 · 1 comment
Open

Init with hsv formant bug #22

bulat-f opened this issue Oct 7, 2015 · 1 comment

Comments

@bulat-f
Copy link

bulat-f commented Oct 7, 2015

For example:

"hsv(100, 75%, 50%)".paint.to_hex # got: "#408020" expected: "#3F7F1F"

In fact #3F7F1F is hsv(100, 75%, 50.2%). Rounding error.

@jfairbank
Copy link
Owner

Hi @fatbulat. Life has been very busy for me the past several months, so I've unfortunately had to neglect this repo for a bit :/

Can you confirm where you're getting #3F7F1F from? I've tried three different online HSV converters (like http://colorizer.org/) and they all give me #408020 like Chroma. If you do find an input producing bad output, please let me know. My math could be off in the code, but in this case it looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants