Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance JS/JSX and TS/TSX #693

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

birkskyum
Copy link

@birkskyum birkskyum commented Mar 18, 2024

While React did popularize the JSX/TSX syntax, there is an increasing number of libraries other than react that rely on JSX/TSX. Notable examples are SolidJS, Vue and Preact which can use the .tsx/.jsx extensions, or in the case of vue have a .vue allowing it to have a dedicated icon.

To account for this diverse ecosystem, this PR therefore remove an obsolete assumption that "jsx = react" and changes the jsx/tsx to a jsx/tsx icons accordingly. This also making jsx<->tsx migration a bit easier, while keeping the spec / test colors as they are, in accordance with #611.

Before
Screenshot 2024-03-18 at 22 06 25

After
Screenshot 2024-03-18 at 22 18 35

@birkskyum birkskyum changed the title Improve JSX and TSX Generalize JSX and TSX Mar 18, 2024
@birkskyum birkskyum changed the title Generalize JSX and TSX Enhance JS/JSX and TS/TSX Mar 18, 2024
@birkskyum
Copy link
Author

@orta , what are your thoughts on this?

@orta
Copy link
Collaborator

orta commented Dec 4, 2024

I'm not wild on the change personally, unless the vscode team have opinions, it's probably not something I'd merge

I think your reasoning is pretty solid, but I don't think it's worth changing everyones defaults for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants