Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gitpod icon and mapping #673

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ShashwatNautiyal
Copy link

Gitpod is an open-source Kubernetes application for ready-to-code cloud development environments.

https://gitpod.io/
https://github.com/gitpod-io/gitpod
https://marketplace.visualstudio.com/items?itemName=gitpod.gitpod-desktop

It has at least 100,000+ downloads of the vs code extension

Preview in VSCode

gitpod

@ShashwatNautiyal
Copy link
Author

@orta

Copy link

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏽 here from Gitpod

@ShashwatNautiyal can you please update the SVG image with this official svg 🙏🏽

@ShashwatNautiyal
Copy link
Author

image

As per the seti-ui the icon must have a single colour, while the official Gitpod SVG has a linear gradient, and the icon size must be 18x18 with a 32x32 frame, while the official Gitpod SVG is 90x99 size.

So I have tweaked the official icon size in the sketch and updated the SVG to match seti-ui requirements.

Copy link

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShashwatNautiyal!

The SVG still looks a bit distorted.

I'm adding below the SVG code in case it helps, using the @orange color described in the README.

<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 32 32">
  <path fill="#E37933" fill-rule="evenodd" d="M17.7376 7.8964c.4868.85279.1908 1.93917-.6611 2.4265l-5.2967 3.0299c-.1402.0802-.2267.2291-.2267.3904v4.7577c0 .1613.0865.3102.2267.3904l4.1909 2.3973c.139.0795.3098.0795.4488 0l4.1909-2.3973c.1402-.0802.2267-.2291.2267-.3904v-2.9588l-3.769 2.1288c-.8545.4827-1.9381.1805-2.4202-.6749-.4822-.8555-.1803-1.9402.6742-2.4229l5.3929-3.046c1.6428-.9279 3.6752.2603 3.6752 2.1485v5.1859c0 1.2146-.6501 2.3362-1.7036 2.9388l-4.8139 2.7537c-1.0395.5947-2.3156.5947-3.3551 0l-4.81394-2.7537C8.65016 21.1977 8 20.0761 8 18.8615v-5.4789c0-1.2147.65016-2.3362 1.70366-2.9388l5.61004-3.20917c.8519-.48732 1.9371-.19103 2.4239.66177Z" clip-rule="evenodd"/>
</svg>

This should improve the icon, see BEFORE/AFTER in the screenshot below:

Icon

@ShashwatNautiyal
Copy link
Author

Updated Gitpod Icon SVG with @gtsiolis SVG.

@gtsiolis
Copy link

gtsiolis commented Jan 30, 2023

Thanks, @ShashwatNautiyal! 🙏

@orta Could you take a look at this or forward to someone that can review and merge this? Cc @jesseweed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants