Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrobble request should use time the track started playing, not the current time #54

Open
csaavedra opened this issue Oct 9, 2023 · 0 comments · May be fixed by #72
Open

Scrobble request should use time the track started playing, not the current time #54

csaavedra opened this issue Oct 9, 2023 · 0 comments · May be fixed by #72
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@csaavedra
Copy link
Contributor

From the spec (https://www.last.fm/api/show/track.scrobble):

timestamp[i] (Required) : The time the track started playing, in UNIX timestamp format (integer number of seconds since 00:00:00, January 1st 1970 UTC). This must be in the UTC time zone.

However the plugin is just using the current time, instead, see

jellyfin-plugin-lastfm/Jellyfin.Plugin.Lastfm/Api/LastfmApiClient.cs

Line 54 in 6c401ee

Timestamp = Helpers.CurrentTimestamp(),

@jesseward jesseward added bug Something isn't working good first issue Good for newcomers labels Dec 7, 2023
@jacob-ewald jacob-ewald linked a pull request Nov 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use start time when scrobbling jacob-ewald/jellyfin-plugin-lastfm
2 participants
@jesseward @csaavedra