Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Open route-links in new tab with modifier key #6

Open
hedefalk opened this issue Nov 2, 2018 · 1 comment
Open

Feature: Open route-links in new tab with modifier key #6

hedefalk opened this issue Nov 2, 2018 · 1 comment

Comments

@hedefalk
Copy link

hedefalk commented Nov 2, 2018 •
edited
Loading

It would be nice to be able to open links in new tab if using modifier with the route-link component.
@hedefalk
Copy link
Author

hedefalk commented Nov 2, 2018

I looked at react-router5 and they did something very simple thing that just using default when no modifier is used:

https://github.com/router5/react-router5/blob/26e4bc05fe896cb19fbb3cfee6cad3b2830adfc3/modules/BaseLink.js#L43

I'll send a PR for this if you want it :)

hedefalk added a commit to hedefalk/marko-router5 that referenced this issue Nov 2, 2018
@hedefalk
adds condition on navigation for route-link
3a2e6f2 
Fixes jesse1983#6
@hedefalk hedefalk mentioned this issue Nov 2, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hedefalk