Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ecma_uint32_to_utf8_string that fill \0 at the end of string #5196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lygstate
Copy link
Contributor

@lygstate lygstate commented Dec 10, 2024

Closes: #5194

Depends on #5199

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]

@lygstate lygstate force-pushed the ecma_uint32_to_utf8_string branch 3 times, most recently from f1817ec to eafb1b1 Compare December 11, 2024 19:22
Introduce lit_utf8_string_t and use it to reduce heap allocation and improve performance

Mark ECMA_STRING_TO_UTF8_STRING/ECMA_STRING_TO_UTF8_STRING_AND_LENGTH do not use heap allocation

Now with lit_utf8_string_t, ECMA_STRING_TO_UTF8_STRING and ECMA_STRING_TO_UTF8_STRING_AND_LENGTH are simplified.
The parameters passed to ECMA_STRING_TO_UTF8_STRING  and ECMA_STRING_TO_UTF8_STRING_AND_LENGTH are reduced and easier to call

The function prototype of ecma_string_get_chars are simplified as:

lit_utf8_size_t ecma_string_get_chars (const ecma_string_t *string_p,
                                       lit_utf8_string_t *string_out_p,
                                       lit_utf8_byte_t *uint32_buff_p,
                                       uint8_t *flags_p);

The macro prototype of ECMA_STRING_TO_UTF8_STRING and ECMA_STRING_TO_UTF8_STRING_AND_LENGTH are simplified as:

#define ECMA_STRING_TO_UTF8_STRING(ecma_str_ptr, /**< ecma string pointer */                           \
                                   utf8_str) /**< [out] lit_utf8_string_t to get */                    \

#define ECMA_STRING_TO_UTF8_STRING_AND_LENGTH(ecma_str_ptr, /**< ecma string pointer */           \
                                              utf8_str) /**< [out] lit_utf8_string_t to get */    \

Now the parameters are reduced. Aslo the calling to ecma_string_get_chars
are largely reduced, in most case, ECMA_STRING_TO_UTF8_STRING/ECMA_STRING_TO_UTF8_STRING_AND_LENGTH is enough.

Because the heap allocation are reduced, the performance should be improved.
And in most case, we only use ECMA_STRING_TO_UTF8_STRING, only when the length is needed, the ECMA_STRING_TO_UTF8_STRING_AND_LENGTH
is called, ECMA_STRING_TO_UTF8_STRING_AND_LENGTH needs to calculate the length that's very slow.

ECMA_FINALIZE_UTF8_STRING is removed, if we have heap allocation situation, use ecma_string_get_chars instead and free it manually

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]
@lygstate lygstate force-pushed the ecma_uint32_to_utf8_string branch from eafb1b1 to db5ec79 Compare December 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecma_uint32_to_utf8_string did not fill string as zero-terminated.
1 participant