Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Creating Dynamic Sidebar Menu #1325

Closed
bulfaitelo opened this issue Dec 5, 2024 · 2 comments
Closed

[FEATURE] Creating Dynamic Sidebar Menu #1325

bulfaitelo opened this issue Dec 5, 2024 · 2 comments
Labels
enhancement Improvement related to this package

Comments

@bulfaitelo
Copy link
Contributor

Is your request related to a problem? Describe it.

It is not necessarily a problem, but rather a feature.

Describe the solution you'd like

We have the sidebar menu and the sidebar search, we could create one that integrated the two, for example:
The first search would be in the menu 'sidebar-menu-search', if it does not exist in the menu the search would direct to the custom search like 'sidebar-custom-search'.

Describe alternatives you've considered

Today, I leave the navbar menu for searches, and the sidebar for menu searches.

Additional context

This change would generally make it easier to use the menu. And forgive me for my English.

@bulfaitelo bulfaitelo added the enhancement Improvement related to this package label Dec 5, 2024
@dfsmania
Copy link
Collaborator

dfsmania commented Dec 5, 2024

@bulfaitelo I'm not sure if I understand correctly your proposing, however, the sidebar menu search is part of the underlying AdminLTE v3.2 package, we just created an easy way to use it here, so we can't touch any logic there. Also, it performs the search directly on the client side whitout any interaction with the server. On the other side, the custom search requires a request to the server and wait for a response with the results of the search. They are for different purposes, and I'm not seeing a clean path to integrate both into one. If you find a way, you are free to propose a PR for this feature.

Regards!

@dfsmania
Copy link
Collaborator

Closed, no feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement related to this package
Projects
None yet
Development

No branches or pull requests

2 participants