Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Configuration for webhook - Missing Advanced #296

Open
iuli72an opened this issue Nov 23, 2022 · 3 comments
Open

Global Configuration for webhook - Missing Advanced #296

iuli72an opened this issue Nov 23, 2022 · 3 comments
Labels

Comments

@iuli72an
Copy link

Jenkins and plugins versions report

Environment
Jenkins: 2.361.3
OS: Linux - 5.4.0-131-generic
---
Office-365-Connector:4.17.0
ace-editor:1.1
ant:481.v7b_09e538fcca
antisamy-markup-formatter:2.7
apache-httpcomponents-client-4-api:4.5.13-138.v4e7d9a_7b_a_e61
authentication-tokens:1.4
authorize-project:1.4.0
bitbucket:223.vd12f2bca5430
bitbucket-pullrequests-filter:0.1.0
blueocean:1.25.8
blueocean-autofavorite:1.2.5
blueocean-bitbucket-pipeline:1.25.8
blueocean-commons:1.25.8
blueocean-config:1.25.8
blueocean-core-js:1.25.8
blueocean-dashboard:1.25.8
blueocean-display-url:2.4.1
blueocean-events:1.25.8
blueocean-git-pipeline:1.25.8
blueocean-github-pipeline:1.25.8
blueocean-i18n:1.25.8
blueocean-jwt:1.25.8
blueocean-personalization:1.25.8
blueocean-pipeline-api-impl:1.25.8
blueocean-pipeline-editor:1.25.8
blueocean-pipeline-scm-api:1.25.8
blueocean-rest:1.25.8
blueocean-rest-impl:1.25.8
blueocean-web:1.25.8
bootstrap4-api:4.6.0-5
bootstrap5-api:5.2.1-3
bouncycastle-api:2.26
branch-api:2.1046.v0ca_37783ecc5
build-failure-analyzer:2.4.0
build-timeout:1.24
caffeine-api:2.9.3-65.v6a_47d0f4d1fe
checks-api:1.8.0
cloud-stats:0.27
cloudbees-bitbucket-branch-source:791.vb_eea_a_476405b
cloudbees-folder:6.758.vfd75d09eea_a_1
cobertura:1.17
code-coverage-api:3.2.0
command-launcher:90.v669d7ccb_7c31
commons-lang3-api:3.12.0-36.vd97de6465d5b_
commons-text-api:1.10.0-27.vb_fa_3896786a_7
config-file-provider:3.11.1
credentials:1189.vf61b_a_5e2f62e
credentials-binding:523.vd859a_4b_122e6
data-tables-api:1.12.1-4
display-url-api:2.3.6
docker-commons:1.21
docker-java-api:3.2.13-37.vf3411c9828b9
docker-plugin:1.2.10
docker-workflow:528.v7c193a_0b_e67c
durable-task:501.ve5d4fc08b0be
echarts-api:5.4.0-1
email-ext:2.92
extended-read-permission:3.2
favorite:2.4.1
font-awesome-api:6.2.0-3
forensics-api:1.16.0
generic-webhook-trigger:1.85.2
git:4.13.0
git-client:3.13.0
git-server:99.va_0826a_b_cdfa_d
github:1.36.0
github-api:1.303-400.v35c2d8258028
github-branch-source:1695.v88de84e9f6b_9
gradle:2.0
handlebars:3.0.8
handy-uri-templates-2-api:2.1.8-22.v77d5b_75e6953
htmlpublisher:1.31
instance-identity:116.vf8f487400980
ionicons-api:31.v4757b_6987003
jackson2-api:2.13.4.20221013-295.v8e29ea_354141
jakarta-activation-api:2.0.1-2
jakarta-mail-api:2.0.1-2
javax-activation-api:1.2.0-5
javax-mail-api:1.6.2-8
jaxb:2.3.7-1
jclouds-jenkins:2.29
jdk-tool:63.v62d2fd4b_4793
jenkins-design-language:1.25.8
jjwt-api:0.11.5-77.v646c772fddb_0
jnr-posix-api:3.1.15-2
job-dsl:1.81
jquery3-api:3.6.1-2
jsch:0.1.55.61.va_e9ee26616e7
junit:1156.vcf492e95a_a_b_0
kubernetes:3734.v562b_b_a_627ea_c
kubernetes-client-api:5.12.2-193.v26a_6078f65a_9
kubernetes-credentials:0.9.0
ldap:2.12
locale:204.v2a_f305fe7e9d
lockable-resources:2.18
mailer:438.v02c7f0a_12fa_4
matrix-auth:3.1.5
matrix-project:785.v06b_7f47b_c631
mercurial:1260.vdfb_723cdcc81
metrics:4.2.10-389.v93143621b_050
mina-sshd-api-common:2.9.1-44.v476733c11f82
mina-sshd-api-core:2.9.1-44.v476733c11f82
momentjs:1.1.1
muuri-api:0.9.5-3
okhttp-api:4.9.3-108.v0feda04578cf
pam-auth:1.10
pipeline-build-step:2.18
pipeline-github-lib:38.v445716ea_edda_
pipeline-graph-analysis:195.v5812d95a_a_2f9
pipeline-groovy-lib:613.v9c41a_160233f
pipeline-input-step:456.vd8a_957db_5b_e9
pipeline-milestone-step:101.vd572fef9d926
pipeline-model-api:2.2118.v31fd5b_9944b_5
pipeline-model-definition:2.2118.v31fd5b_9944b_5
pipeline-model-extensions:2.2118.v31fd5b_9944b_5
pipeline-rest-api:2.27
pipeline-stage-step:296.v5f6908f017a_5
pipeline-stage-tags-metadata:2.2118.v31fd5b_9944b_5
pipeline-stage-view:2.27
plain-credentials:139.ved2b_9cf7587b
plugin-util-api:2.18.0
popper-api:1.16.1-3
popper2-api:2.11.6-2
prism-api:1.29.0-1
pubsub-light:1.17
resource-disposer:0.20
scm-api:621.vda_a_b_055e58f7
script-security:1189.vb_a_b_7c8fd5fde
select2-api:4.0.13-8
snakeyaml-api:1.32-86.ve3f030a_75631
sse-gateway:1.26
ssh-agent:295.v9ca_a_1c7cc3a_a_
ssh-credentials:305.v8f4381501156
ssh-slaves:1.821.vd834f8a_c390e
sshd:3.249.v2dc2ea_416e33
stashNotifier:1.28
structs:324.va_f5d6774f3a_d
throttle-concurrents:2.9
timestamper:1.20
token-macro:308.v4f2b_ed62b_b_16
trilead-api:1.67.vc3938a_35172f
variant:59.vf075fe829ccb
workflow-aggregator:590.v6a_d052e5a_a_b_5
workflow-api:1200.v8005c684b_a_c6
workflow-basic-steps:994.vd57e3ca_46d24
workflow-cps:2803.v1a_f77ffcc773
workflow-cps-global-lib:588.v576c103a_ff86
workflow-durable-task-step:1210.va_1e5d77e122b
workflow-job:1254.v3f64639b_11dd
workflow-multibranch:716.vc692a_e52371b_
workflow-scm-step:400.v6b_89a_1317c9a_
workflow-step-api:639.v6eca_cd8c04a_a_
workflow-support:839.v35e2736cfd5c
ws-cleanup:0.43

What Operating System are you using (both controller, and any agents involved in the problem)?

I am using Jenkins 2.361.3 with the version of Office 365 Connector Version 4.17.0, hosted on a RKE K8S cluster (image jenkins/jenkins:lts).

Reproduction steps

  1. Go to the Jenkins -> Dashboard -> Manage Jenkins -> Configure System -> Office 365 Connector
  2. The is a missing Advanced.... button to allow Global plugin config values to be used as default in jobs, like is described into documentation.

What I get with above mentioned versions is the following:
image

Expected Results

image
image

Actual Results

Missing Advanced... or possibility to use globally the plugin

Anything else?

No response

@iuli72an iuli72an added the bug label Nov 23, 2022
@damianszczepanik
Copy link
Member

What makes different screenshot where you have and where button is missing ?

@iulicapra
Copy link

iulicapra commented Dec 7, 2022

The first screenshot is from the Jenkins -> Dashboard -> Manage Jenkins -> Configure System -> Office 365 Connector location. The screenshots from the Expected results are taken from what seems to be described in the Plugin's documentation.

We are using an Organization Folder, for which the created Multibranch Pipelines do not allow us to use this Plugin working Globally, from its own designed functionality. Why have an Ofiice 365 Connector with a URL and Name statements in Jenkin's system configuration, if this plugin cannot be used Globally or setup properly per each automatically created Multibranch Pipelines from the GUI?

This means that the Office365Connector plugin works specifically ONLY in the manually created Multibranch pipeline.

In other words, if we try to create specific individual Multibranch Pipelines, we can see the Add Webhook button as well as the Advanced subsection to tick all the modifiers like Notify Success, Notify Unstable, etc. But this is not very practical in Organizational Folder context. In Organization Folder context, each repo will need its own Jenkinsfile to have defined and maintained Groovy properties statements, something that is neither practical nor useful.

The Global Configuration in Init Hook part of the documentation does not cover how these individual modifiers of the plugin can be achieved either.

These are the discrepancies explained altogether. I hope it makes sense.

@damianszczepanik
Copy link
Member

Based on the code ans what Jenkins present I can say that advanced configuration is available for the job configuration https://github.com/jenkinsci/office-365-connector-plugin/blob/master/src/main/resources/jenkins/plugins/office365connector/Webhook/config.jelly#L11 but not for a global https://github.com/jenkinsci/office-365-connector-plugin/blob/master/src/main/resources/jenkins/plugins/office365connector/Webhook/global.jelly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants