Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to split credentials secret in 2. #313

Open
apogrebnyak opened this issue Mar 31, 2020 · 5 comments
Open

Need to split credentials secret in 2. #313

apogrebnyak opened this issue Mar 31, 2020 · 5 comments
Labels
enhancement New feature or request not-stale

Comments

@apogrebnyak
Copy link

apogrebnyak commented Mar 31, 2020

Currently jenkins-operator-credentials-<cr-name> secret contains both credentials for operator Admin user and API token, namely

  • user
  • password
  • token
  • tokenCreationTime

I think the original intent was to generate all values in this secret on the operator side.

However with requirement for LDAP admin user be written to this secret by external process we now have a disconnect.

If external process manages the content of the secret (i.e. terraform), then on every successive update the external process will delete token and tokenCreationTime fields, as it knows nothing about these fields.

In order to allow for external tool managing admin credentials, I propose splitting token and tokenCreationTime out of jenkins-operator-credentials-<cr-name> secret into its own jenkins-operator-api-token-<cr-name> secret.

This #133 (comment) describes the problem as related to LDAP configuration

@tumevoiz tumevoiz added the enhancement New feature or request label Apr 1, 2020
@tomaszsek tomaszsek assigned tomaszsek and unassigned tomaszsek Apr 1, 2020
@mkarebski
Copy link

I'm on it.

@apogrebnyak
Copy link
Author

As a workaround, with terraform I've created a null_resource with trigger of base64sha512 of username and password.
When triggered it passes username and password through environment block to local-exec provisioner, that applies a secret.

@tomaszsek
Copy link

Hi @apogrebnyak,

In terraform I would consider using
the https://www.terraform.io/docs/configuration/resources.html#ignore_changes ;)

Cheers

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this issue is still affecting you, just comment with any updates and we'll keep it open. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@Sig00rd Sig00rd added this to the New API milestone Jul 28, 2021
@stale stale bot removed the stale label Jul 28, 2021
@Sig00rd Sig00rd added the frozen label Jul 28, 2021
@Sig00rd Sig00rd removed this from the New API milestone Jul 28, 2021
@Sig00rd
Copy link

Sig00rd commented Jul 28, 2021

Freezing this for it to stay in the backlog, since it's out of scope of next release but we're planning on working on this in the newer API.

@github-actions github-actions bot added the stale label May 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2023
@brokenpip3 brokenpip3 reopened this May 19, 2023
@stale stale bot removed the stale label May 19, 2023
@brokenpip3 brokenpip3 removed the frozen label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not-stale
Projects
None yet
Development

No branches or pull requests

6 participants