Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Packaging: Avoid using the full dotnet SDK #212

Open
dduportal opened this issue Jan 17, 2022 · 7 comments
Open

Windows Packaging: Avoid using the full dotnet SDK #212

dduportal opened this issue Jan 17, 2022 · 7 comments

Comments

@dduportal
Copy link
Contributor

Hello @MarkEWaite @timja , I'm facing a size/speed issue around the Windows packaging step.

The size of the image mcr.microsoft.com/dotnet/framework/sdk:3.5 is 15Gb and need to be pull each time we run a release process (or a build in jenkins-infra/docker-packaging#23).

This issue already exists during the weekly and LTS releases (seen with @Wadeck and @daniel-beck during the last security update) and the time of pulling this images is coherent with the docker-packaging build times: around 14 min only for pulling the base image.

I wonder what part of the dotnet SDK are strictly required for generating the MSI package and if we couldn't only install these elements instead of pulling the full sized image. WDYT?

@dduportal
Copy link
Contributor Author

For tomorrow's release, I would want to try the version 4.8 of the dotnet sdk: the Docker image is 12.8 Gb : still 3 Gb less.

@timja
Copy link
Member

timja commented Jan 17, 2022

Either @olblak or @slide may know

@dduportal
Copy link
Contributor Author

As per https://github.com/jenkinsci/packaging#pre-requisites:

This Jenkins needs to have a Windows build agent that has WiX Toolset (currently 3.5), msbuild, cygwin and .net 2.0. This build agent is used to build MSI packages, which can be only built on Windows.

Not sure if ".net 2.0" covers the whole SDK framework?

@timja
Copy link
Member

timja commented Jan 17, 2022

wix3 requires at least .net 3.5

wix4 which is in development uses .net core

@dduportal
Copy link
Contributor Author

I'm gonna try installing .net SDK + wix in the inbound-agent Docker image instead of pulling the whole 12 Gb of framework then

@timja
Copy link
Member

timja commented Jan 17, 2022

I think wix will require the whole framework but worth a try

@slide
Copy link
Contributor

slide commented Jan 18, 2022

Those pre-requisites are not correct. Cygwin is not needed. .Net core will not work. It must be 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants