We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemoveProperty
https://github.com/openrewrite/rewrite/blob/main/rewrite-maven/src/main/java/org/openrewrite/maven/RemoveProperty.java doesn't check if the property is referenced anywhere on the pom
Those could lead to broken pom
Improve this recipe or create our own (we can reuse the visitors for example)
For example https://github.com/openrewrite/rewrite/blob/main/rewrite-maven/src/main/java/org/openrewrite/maven/search/FindProperties.java#L67 could be used to mark property used in the pom (see) https://github.com/openrewrite/rewrite/blob/main/rewrite-maven/src/test/java/org/openrewrite/maven/search/FindPropertiesTest.java#L28
Then we can remove all properties not used in the pom
This would not cover multi-module plugin
No response
The text was updated successfully, but these errors were encountered:
jonesbusy
Successfully merging a pull request may close this issue.
What feature do you want to see added?
https://github.com/openrewrite/rewrite/blob/main/rewrite-maven/src/main/java/org/openrewrite/maven/RemoveProperty.java doesn't check if the property is referenced anywhere on the pom
Those could lead to broken pom
Improve this recipe or create our own (we can reuse the visitors for example)
For example https://github.com/openrewrite/rewrite/blob/main/rewrite-maven/src/main/java/org/openrewrite/maven/search/FindProperties.java#L67 could be used to mark property used in the pom (see) https://github.com/openrewrite/rewrite/blob/main/rewrite-maven/src/test/java/org/openrewrite/maven/search/FindPropertiesTest.java#L28
Then we can remove all properties not used in the pom
This would not cover multi-module plugin
Upstream changes
No response
Are you interested in contributing this feature?
No response
The text was updated successfully, but these errors were encountered: