Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule jenkins/unsafe-classes resolves class paths against repository root #26

Open
NotMyFault opened this issue Apr 1, 2023 · 1 comment

Comments

@NotMyFault
Copy link
Member

It appears, the unsafe-classes rule resolves the link against the repository root:

Screenshot 2023-04-01 at 20 16 05

Obviously, the preview won't work because the classes aren't present in any of the plugin repositories.

Maybe we can unlink the references and escape them, given the name already represents the FQN you can look up.

See https://github.com/jenkinsci/job-config-history-plugin/security/code-scanning/1 for a real world example.

@daniel-beck
Copy link
Contributor

Thanks for letting me know. TBH this seems more like a bug in CodeQL/GitHub itself not recognizing that the class being referenced isn't in this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants