Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing exclamation mark in jio footer #252

Open
NotMyFault opened this issue Mar 28, 2023 · 7 comments · May be fixed by #253
Open

Missing exclamation mark in jio footer #252

NotMyFault opened this issue Mar 28, 2023 · 7 comments · May be fixed by #253
Labels
bug

Comments

@NotMyFault
Copy link
Member

Problem with this page

https://accounts.jenkins.io/login

Expected behavior

If you can report a problem with the page, the interface is prefixed with a warning symbol, as seen in the footer on plugins.jenkins.io for example.

Actual behavior

There's no warning symbol on accounts.j.io, which looks odd.

We're using the following couple of lines to place the footer:

account-app/src/main/resources/org/jenkinsci/account/taglib/layout.jelly

Lines 90 to 91 in 234f912

<jio-footer id='footer' style="position:absolute; width:100%" property="https://accounts.jenkins.io"
reportAProblemTemplate="1-bug.yml" githubRepo="jenkins-infra/account-app" githubBranch="main"></jio-footer>

@halkeye Is there anything in particular we need to add to ensure our footer interfaces look the same like on jenkins.io or plugins.jenkins.io?

Possible solution

No response
@NotMyFault NotMyFault added the bug label Mar 28, 2023
@halkeye
Copy link
Member

halkeye commented Mar 28, 2023

Yea you probably need ion-icons which is not bundled. You can find them in Jenkins.io layout templates

@NotMyFault
Copy link
Member Author

Yea you probably need ion-icons which is not bundled. You can find them in Jenkins.io layout templates

Thanks for the pointer, I thought they were bundled or something.

@NotMyFault NotMyFault linked a pull request Mar 28, 2023 that will close this issue
Open
@halkeye
Copy link
Member

halkeye commented Mar 28, 2023

Jenkins.ion has been using it independently before this so I choose to keep things smaller.

@NotMyFault
Copy link
Member Author

Jenkins.ion has been using it independently before this so I choose to keep things smaller.

If they are needed for footer links, it would make sense to bundle them in jio components I'd say, no? jenkins.io uses ionicons on more occasions than the footer. Hence, they have been around longer, but for pages which don't use ionicons at all, jio bundling it sounds preferable to me.

@halkeye
Copy link
Member

halkeye commented Mar 28, 2023

It would make the bundle size much bigger and then loaded twice.

I'm not against it just explaining what I was thinking

Could just be listed as explicit dependency or lazy loads from cdn if not found

@timja
Copy link
Member

timja commented Mar 28, 2023 •
edited
Loading

Can we bundle just the icon required? or just inline SVG?

@halkeye
Copy link
Member

halkeye commented Mar 28, 2023

probably doable if someone wants to figure out how

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ionicons to script set NotMyFault/account-app
3 participants
@halkeye @NotMyFault @timja