From 7fadd9bcbbe97e82198e647a1a72442d43f19fbe Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Thu, 7 Nov 2024 14:36:50 -0500 Subject: [PATCH 1/2] Remove unavailable expo version --- components/AppInfoFooter.js | 5 ----- components/__tests__/AppInfoFooter.test.js | 2 -- langs/en.json | 3 +-- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/components/AppInfoFooter.js b/components/AppInfoFooter.js index cd3aa11ae..b5de21dab 100644 --- a/components/AppInfoFooter.js +++ b/components/AppInfoFooter.js @@ -7,7 +7,6 @@ import { useNavigation } from '@react-navigation/native'; import Constants from 'expo-constants'; import React, { useContext } from 'react'; -import { useTranslation } from 'react-i18next'; import { StyleSheet, View } from 'react-native'; import { Text, ThemeContext } from 'react-native-elements'; @@ -16,7 +15,6 @@ import { getAppName } from '../utils/Device'; const AppInfoFooter = () => { const navigation = useNavigation(); - const { t } = useTranslation(); const { theme } = useContext(ThemeContext); const textStyle = { @@ -38,9 +36,6 @@ const AppInfoFooter = () => { {`${Constants.nativeAppVersion} (${Constants.nativeBuildVersion})`} - - {t('settings.expoVersion', { version: Constants.expoVersion })} - ); }; diff --git a/components/__tests__/AppInfoFooter.test.js b/components/__tests__/AppInfoFooter.test.js index cee737a0e..fb84f9aed 100644 --- a/components/__tests__/AppInfoFooter.test.js +++ b/components/__tests__/AppInfoFooter.test.js @@ -29,7 +29,6 @@ jest.mock('@react-navigation/native', () => { describe('AppInfoFooter', () => { it('should render correctly', () => { - Constants.expoVersion = '39.0.0'; Constants.nativeAppVersion = '1.0.0'; Constants.nativeBuildVersion = '1.0.0.0'; Device.osName = 'Test OS'; // eslint-disable-line no-import-assign, import/namespace @@ -45,6 +44,5 @@ describe('AppInfoFooter', () => { fireEvent(appName, 'onLongPress'); expect(mockNavigate).toHaveBeenCalledWith(Screens.DevSettingsScreen); expect(getByTestId('app-version')).toHaveTextContent('1.0.0 (1.0.0.0)'); - expect(getByTestId('expo-version')).toHaveTextContent('Expo Version: 39.0.0'); }); }); diff --git a/langs/en.json b/langs/en.json index 1177905eb..58bc01923 100644 --- a/langs/en.json +++ b/langs/en.json @@ -65,8 +65,7 @@ "lightTheme": "Use Light Theme", "systemTheme": "Use System Theme", "rotationLock": "Rotation Lock", - "tabLabels": "Show Tab Labels", - "expoVersion": "Expo Version: {{version}}" + "tabLabels": "Show Tab Labels" }, "links": { "website": "Jellyfin Website", From 2aa6dc43b9e725efbd1ecd487958455247254507 Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Thu, 7 Nov 2024 14:58:40 -0500 Subject: [PATCH 2/2] Update test snapshot --- .../__snapshots__/SettingsScreen.test.js.snap | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/screens/__tests__/__snapshots__/SettingsScreen.test.js.snap b/screens/__tests__/__snapshots__/SettingsScreen.test.js.snap index de1786521..6a2ccf96e 100644 --- a/screens/__tests__/__snapshots__/SettingsScreen.test.js.snap +++ b/screens/__tests__/__snapshots__/SettingsScreen.test.js.snap @@ -720,17 +720,6 @@ exports[`SettingsScreen should render correctly 1`] = ` > mock (mock) - - Expo Version: mock -