Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon Rectangle missing a "bonus" e #23

Open
dmoa opened this issue Jun 25, 2021 · 2 comments
Open

Polygon Rectangle missing a "bonus" e #23

dmoa opened this issue Jun 25, 2021 · 2 comments

Comments

@dmoa
Copy link

dmoa commented Jun 25, 2021

image

The polygon rectangle collision page and the code that goes with it misses out on checking whether a rectangle completely engulfs a polygon.

You could do Rectangle Point for all the points of the polygon, but I think it's worth writing this as a possibility just as polygon point is written as a possibility.

@dmoa
Copy link
Author

dmoa commented Jun 25, 2021

I've also just noticed that in the source code that polygonPoint checks the same point of a rectangle as many times as there are points of the polygon. Instead, from my understanding, it should run polygonPoint with each of the 4 points of the rectangle.

@jeffThompson
Copy link
Owner

Thanks for noticing this! I have a pile of similar (awesome) suggestions I need to get through, so apologies if you don't see a fix immediately – it's coming I promise! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants