Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line to Rect does not check if the line is completely inside the rectangle. #19

Open
treeform opened this issue Oct 11, 2020 · 3 comments · May be fixed by #21
Open

Line to Rect does not check if the line is completely inside the rectangle. #19

treeform opened this issue Oct 11, 2020 · 3 comments · May be fixed by #21

Comments

@treeform
Copy link

Not sure if that on purpose or not.

Simply adding a pointRect fixes the issue.
@jeffThompson
Copy link
Owner

Thanks! Let me take a look and I'll get back to this asap.

@aryan02420
Copy link

hey, i fixed this issue for my own project.
can i try a PR?

@jeffThompson
Copy link
Owner

Sure that would be great, thanks!

@aryan02420 aryan02420 linked a pull request Mar 15, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Line/Rect collision fix aryan02420/CollisionDetection
3 participants
@treeform @jeffThompson @aryan02420