Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A #; without something to comment out yields an unrecoverable error #102

Closed
Release-Candidate opened this issue Apr 3, 2023 · 0 comments · Fixed by #104
Closed

A #; without something to comment out yields an unrecoverable error #102

Release-Candidate opened this issue Apr 3, 2023 · 0 comments · Fixed by #104

Comments

@Release-Candidate
Copy link

Entering a #; in the last line of a file results in an unrecoverable error, deleting the #; does not make the error go away.
It works when first entering the S-expression to comment out and then adding the #;.

like:

#lang racket

#;

Output of the LSP:

sub1: contract violation
  expected: number?
  given: #f
  context...:
   /Users/roland/Library/Racket/8.8/pkgs/racket-langserver/check-syntax.rkt:19:0
   /Applications/Racket v8.8/collects/racket/private/more-scheme.rkt:163:2: select-handler/no-breaks
   /Applications/Racket v8.8/collects/racket/logging.rkt:43:0: with-intercepted-logging
   /Users/roland/Library/Racket/8.8/pkgs/racket-langserver/check-syntax.rkt:77:0: check-syntax
   /Applications/Racket v8.8/collects/racket/contract/private/arrow-val-first.rkt:486:18
   /Users/roland/Library/Racket/8.8/pkgs/racket-langserver/queue-only-latest.rkt:9:0: do-check-and-stuff!
   /Users/roland/Library/Racket/8.8/pkgs/racket-langserver/queue-only-latest.rkt:33:0: check

See: Eugleo/magic-racket#104
@6cdh 6cdh mentioned this issue Apr 5, 2023
Open
jryans added a commit to jryans/racket-langserver that referenced this issue Apr 7, 2023
@jryans
Use end-of-file as fallback position for exceptions
8084d26 
Some reader exceptions do not have position information. This uses end-of-file
as a reasonable guess, so we can at least highlight some part of the file.
Handing this case resolves a langserver contract error.

Fixes jeapostrophe#102
jryans added a commit to jryans/racket-langserver that referenced this issue Apr 7, 2023
@jryans
Use end-of-file as fallback position for exceptions
550378f 
Some reader exceptions do not have position information. This uses end-of-file
as a reasonable guess, so we can at least highlight some part of the file.
Handing this case resolves a langserver contract error.

Fixes jeapostrophe#102
@jryans jryans mentioned this issue Apr 7, 2023
Merged
jeapostrophe pushed a commit that referenced this issue Apr 7, 2023
@jryans @jeapostrophe
Use end-of-file as fallback position for exceptions
570b195 
Some reader exceptions do not have position information. This uses end-of-file
as a reasonable guess, so we can at least highlight some part of the file.
Handing this case resolves a langserver contract error.

Fixes #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use end-of-file as fallback position for exceptions jryans/racket-langserver
1 participant
@Release-Candidate