Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video marker #19

Open
ndao opened this issue Jul 31, 2016 · 4 comments
Open

video marker #19

ndao opened this issue Jul 31, 2016 · 4 comments

Comments

@ndao
Copy link

ndao commented Jul 31, 2016

@jeanpan Can we add a video marker to indicate it's a video? Right now it just blends into the photos. Maybe another prop to accept a video marker?
@joshuapinter
Copy link

Did anybody get anywhere with this?

joshuapinter added a commit to cntral/react-native-camera-roll-picker that referenced this issue Jul 20, 2020
@joshuapinter
Show video icon marker for video files.
c64116a 
Otherwise, you can't tell which thumbnail is an image and which is a video, a very important distinction in most cases.

Addresses jeanpan#19.
joshuapinter added a commit to cntral/react-native-camera-roll-picker that referenced this issue Jul 20, 2020
@joshuapinter
Show video icon marker for video files.
f033c09 
Otherwise, you can't tell which thumbnail is an image and which is a video, a very important distinction in most cases.

Addresses jeanpan#19.
joshuapinter added a commit to cntral/react-native-camera-roll-picker that referenced this issue Jul 20, 2020
@joshuapinter
Show video icon marker for video files.
5d31804 
Otherwise, you can't tell which thumbnail is an image and which is a video, a very important distinction in most cases.

Addresses jeanpan#19.
@joshuapinter
Copy link

joshuapinter commented Jul 30, 2020 •
edited
Loading

FYI, our company, CNTRAL, forked this library and added a video marker on all video thumbnails, in case anybody wants to use it. Later I'll submit a PR to get it merged into the main repo:

https://github.com/cntral/react-native-camera-roll-picker/

Here's a sneak peak of how it looks - image file on the left, video file on the right:

device-2020-07-30-142221

joshuapinter added a commit to cntral/react-native-camera-roll-picker that referenced this issue Dec 2, 2020
@joshuapinter
Show video icon marker for video files.
118557b 
Otherwise, you can't tell which thumbnail is an image and which is a video, a very important distinction in most cases.

Addresses jeanpan#19.
joshuapinter added a commit to cntral/react-native-camera-roll-picker that referenced this issue Dec 2, 2020
@joshuapinter
Show video icon marker for video files.
6b58766 
Otherwise, you can't tell which thumbnail is an image and which is a video, a very important distinction in most cases.

Addresses jeanpan#19.

Also add `accessibilityLabel` for "videoMarker" for ease of targetting in automated testing.
@joshuapinter joshuapinter mentioned this issue Dec 2, 2020
Open
@joshuapinter
Copy link

Created a PR with this feature to get it merged in.

#111

@bacarybruno
Copy link

Hello. I added a videoMarker prop to this package @kebetoo/camera-roll-picker which was rewritten using hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuapinter @ndao @bacarybruno