Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass boolean tool options as strings #3191

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix: pass boolean tool options as strings #3191

merged 2 commits into from
Nov 25, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Nov 25, 2024

Fixes #3189

@jdx jdx enabled auto-merge (squash) November 25, 2024 01:25
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-18.73% 36.36%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8fee82e) 22159 17142 77.36%
Head commit (736d0a4) 42733 (+20574) 25055 (+7913) 58.63% (-18.73%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3191) 11 4 36.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx merged commit 2c241cd into main Nov 25, 2024
29 checks passed
@jdx jdx deleted the toml-bools branch November 25, 2024 01:34
Copy link

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main x -- echo 19.1 ± 0.7 17.8 24.4 1.20 ± 0.05
mise-2024.11.28 x -- echo 15.9 ± 0.3 15.0 17.1 1.00
mise x -- echo 19.1 ± 0.8 17.7 26.4 1.20 ± 0.06

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main env 15.6 ± 0.9 14.3 25.1 1.23 ± 0.08
mise-2024.11.28 env 12.7 ± 0.4 11.7 13.9 1.00
mise env 15.9 ± 1.3 14.4 38.0 1.26 ± 0.11

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main hook-env 15.5 ± 0.8 14.3 25.3 1.26 ± 0.08
mise-2024.11.28 hook-env 12.3 ± 0.3 11.7 15.2 1.00
mise hook-env 15.8 ± 0.6 14.4 17.7 1.29 ± 0.06

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main ls 13.8 ± 0.9 12.8 26.3 1.06 ± 0.08
mise-2024.11.28 ls 13.1 ± 0.4 12.4 16.4 1.00
mise ls 13.4 ± 0.4 12.7 14.7 1.02 ± 0.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding the new locked = false for cargo backend breaks toml parsing
1 participant