Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook-env: keep prepended PATH entries in front #1150

Merged
merged 1 commit into from
Dec 13, 2023
Merged

hook-env: keep prepended PATH entries in front #1150

merged 1 commit into from
Dec 13, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Dec 13, 2023

With this change, if you manually run PATH="/foo:$PATH" in
your shell after activating rtx, rtx will keep "/foo" in front of its own PATH entries.
Fixes #863

With this change, if you manually run PATH="/foo:$PATH" in
your shell after activating rtx, rtx will keep "/foo" in front of its own PATH entries.
Fixes #863
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.09s
✅ BASH bash-exec 19 0 0.04s
✅ BASH shellcheck 19 0 0.33s
✅ BASH shfmt 19 0 0 0.04s
✅ DOCKERFILE hadolint 7 0 0.14s
✅ EDITORCONFIG editorconfig-checker 468 0 0.51s
✅ JSON eslint-plugin-jsonc 7 0 0 1.0s
✅ JSON jsonlint 6 0 0.13s
✅ JSON prettier 7 0 0 0.65s
✅ JSON v8r 7 0 4.23s
✅ MARKDOWN markdownlint 13 0 0 2.72s
✅ MARKDOWN markdown-link-check 13 0 10.42s
✅ MARKDOWN markdown-table-formatter 13 0 0 0.4s
✅ PYTHON bandit 1 0 0.76s
✅ PYTHON black 1 0 0 0.69s
✅ PYTHON flake8 1 0 0.42s
✅ PYTHON isort 1 0 0 0.34s
✅ PYTHON mypy 1 0 2.19s
✅ PYTHON pylint 1 0 1.23s
✅ PYTHON pyright 1 0 6.05s
✅ PYTHON ruff 1 0 0 0.04s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 2.62s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 2.14s
✅ REPOSITORY syft yes no 0.67s
✅ REPOSITORY trivy-sbom yes no 0.99s
✅ REPOSITORY trufflehog yes no 2.79s
✅ RUBY rubocop 2 0 0 4.93s
✅ RUST clippy yes no 102.42s
✅ XML xmllint 5 0 0 0.04s
✅ YAML prettier 12 0 0 1.2s
✅ YAML v8r 12 0 12.43s
✅ YAML yamllint 12 0 0.4s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (784d153) 86.14% compared to head (cec68cc) 84.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1150      +/-   ##
==========================================
- Coverage   86.14%   84.37%   -1.78%     
==========================================
  Files         138      138              
  Lines       12706    12718      +12     
==========================================
- Hits        10946    10731     -215     
- Misses       1760     1987     +227     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx merged commit 9160c4f into main Dec 13, 2023
7 of 8 checks passed
@jdx jdx deleted the non-aggressive branch December 13, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rtx-activate: less aggressive PATH modifications
1 participant