Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CloudWatch resources #75

Open
aghassemlouei opened this issue Feb 22, 2020 · 4 comments
Open

Support for CloudWatch resources #75

aghassemlouei opened this issue Feb 22, 2020 · 4 comments

Comments

@aghassemlouei
Copy link
Contributor

aghassemlouei commented Feb 22, 2020

Requesting addition of AWS CloudWatch Logs, Alarms, and Events as time permits.

@jckuester
Copy link
Owner

FYI, aws_cloudwatch_log_group released in https://github.com/cloudetc/awsweeper/releases/tag/v0.7.0

@aghassemlouei
Copy link
Contributor Author

Can confirm that cloudwatch log group support has been added and functions as of v0.7.0 in us-gov-west-1 region. Opened up #95 to include it in the all.yml but it looks like it's failing on an unrelated vpc test tag build.

Nevertheless, this issue can either be repurposed to include the following components or open individual ones accordingly:

  • CloudWatch Alarms
  • CloudWatch Events

@jckuester
Copy link
Owner

jckuester commented May 8, 2020

@aghassemlouei thanks that you can confirm that cloudwatch log group support is working. Indeed, I missed to add the resource to all.yml. Thanks for the hint.

FYI, soon one will be able to delete all resource types without the superfluous way of having them all listed in all.yml. I probably will implement a --delete-all flag or so instead, let's see.

Don't worry about the failing tests. They require credentials for my personal AWS account and for security reasons only repo owners can run them. It's probably a good idea for me to add a note in the README that the travis build will fail for PRs coming from forks.

Feel free to run tests (https://github.com/cloudetc/awsweeper#acceptance-tests) against your AWS account, but you don't have to; I will take care of running them once the PR looks good.

@aghassemlouei
Copy link
Contributor Author

Bumping this thread as there is a rather large need for both resources and as of 0.11.1 it's still unavailable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants