Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update highlight.js version and add CDN link for jquery.mark.js #26

Closed
wants to merge 1 commit into from

Conversation

kawana77b
Copy link

@kawana77b kawana77b commented Jul 9, 2023

Fix #23, Fix #25

This PR updates the default template to correspond to the current latest DocFX 2.67.5 update.

How to fix

I suggest a patch to update the highlight.js link in the templates to the latest hosted version 11.7.0.
I also suggest adding a CDN link for jquery.mark.min.js.
These fixes ensure that errors and display disturbances that occur when using the current DocFx version are suppressed.

Relevant information

About #23, This PR also relates to and follows the following DocFx issue: dotnet/docfx#8873

@kawana77b
Copy link
Author

This PR has been deemed stale and has been closed.

@kawana77b kawana77b closed this Sep 16, 2023
@luigimannoni
Copy link

+1, hitting the same issue, would be good to see this merged into the master branch. I'm relying my build on your fix branch @kawana77b :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants