Handle PAM_RUSER and PAM_USER being identical #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warns if PAM_RUSER and PAM_USER are identical. Bails out if additionally allow_user_owned_authorized_keys_file is enabled. If authorized_keys_file is allowed to be owned by user, and user is identical with ruser, this means that the calling user (i.e. ruser) can add arbitrary keys to it, thus rendering the whole PAM step useless. Fixes jbeverly#17, but will cause the module to stop working in the described situation. This is fine, as in this scenario, this module poses a massive security gap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warns if PAM_RUSER and PAM_USER are identical. Bails out if additionally
allow_user_owned_authorized_keys_file is enabled.
If authorized_keys_file is allowed to be owned by user, and user is identical
with ruser, this means that the calling user (i.e. ruser) can add arbitrary keys
to it, thus rendering the whole PAM step useless.
Fixes #17, but will cause the module to stop working in the described situation.
This is fine, as in this scenario, this module poses a massive security gap.