From c1f35ad7f64a75a507a1172834e488a6cda946e2 Mon Sep 17 00:00:00 2001 From: Enguerrand Date: Thu, 17 Nov 2022 10:56:35 +0100 Subject: [PATCH] Remove force-instrumented-runtime configure option (#11660) --- Makefile.config.in | 1 - configure | 19 ------------------- configure.ac | 10 ---------- utils/clflags.ml | 5 +---- utils/config.fixed.ml | 1 - utils/config.generated.ml.in | 1 - utils/config.mli | 4 ---- 7 files changed, 1 insertion(+), 40 deletions(-) diff --git a/Makefile.config.in b/Makefile.config.in index c0559552dbee..0b83f398b5b3 100644 --- a/Makefile.config.in +++ b/Makefile.config.in @@ -235,7 +235,6 @@ TARGET=@target@ HOST=@host@ FLAMBDA=@flambda@ WITH_FLAMBDA_INVARIANTS=@flambda_invariants@ -FORCE_INSTRUMENTED_RUNTIME=@force_instrumented_runtime@ WITH_CMM_INVARIANTS=@cmm_invariants@ FORCE_SAFE_STRING=true DEFAULT_SAFE_STRING=true diff --git a/configure b/configure index 7afd85dc6881..443a7af06691 100755 --- a/configure +++ b/configure @@ -780,7 +780,6 @@ build QS ocaml_libdir ocaml_bindir -force_instrumented_runtime compute_deps stdlib_manpages PACKLD @@ -969,7 +968,6 @@ enable_installing_bytecode_programs enable_native_compiler enable_flambda enable_flambda_invariants -enable_force_instrumented_runtime enable_cmm_invariants with_target_bindir enable_reserved_header_bits @@ -1658,8 +1656,6 @@ Optional Features: --enable-flambda enable flambda optimizations --enable-flambda-invariants enable invariants checks in flambda - --force-instrumented-runtime - force the usage of the instrumented runtime --enable-cmm-invariants enable invariants checks in Cmm --enable-reserved-header-bits=BITS reserve BITS (between 0 and 31) bits in block @@ -3239,7 +3235,6 @@ toolchain="cc" profinfo=false profinfo_width=0 instrumented_runtime=false -force_instrumented_runtime=false instrumented_runtime_libs="" bootstrapping_flexdll=false flexdll_dir= @@ -3397,7 +3392,6 @@ OCAML_VERSION_SHORT=5.1 - ## Generated files @@ -3828,13 +3822,6 @@ then : fi -# Check whether --enable-force-instrumented-runtime was given. -if test ${enable_force_instrumented_runtime+y} -then : - enableval=$enable_force_instrumented_runtime; -fi - - # Check whether --enable-cmm-invariants was given. if test ${enable_cmm_invariants+y} then : @@ -16243,12 +16230,6 @@ rm -f core conftest.err conftest.$ac_objext conftest.beam conftest.$ac_ext ;; esac -if test "x$enable_force_instrumented_runtime" = "xyes" -then : - force_instrumented_runtime=true - -fi - # The instrumented runtime is built by default # if the proper clock source is found. # If asked via --enable-instrumented-runtime, configuration fails if the proper diff --git a/configure.ac b/configure.ac index c4fd1bc0be6c..071e42a6bf73 100644 --- a/configure.ac +++ b/configure.ac @@ -64,7 +64,6 @@ toolchain="cc" profinfo=false profinfo_width=0 instrumented_runtime=false -force_instrumented_runtime=false instrumented_runtime_libs="" bootstrapping_flexdll=false flexdll_dir= @@ -212,7 +211,6 @@ AC_SUBST([mkexe_ldflags_exp]) AC_SUBST([PACKLD]) AC_SUBST([stdlib_manpages]) AC_SUBST([compute_deps]) -AC_SUBST([force_instrumented_runtime]) AC_SUBST([ocaml_bindir]) AC_SUBST([ocaml_libdir]) AC_SUBST([QS]) @@ -417,10 +415,6 @@ AC_ARG_ENABLE([flambda-invariants], [AS_HELP_STRING([--enable-flambda-invariants], [enable invariants checks in flambda])]) -AC_ARG_ENABLE([force-instrumented-runtime], - [AS_HELP_STRING([--force-instrumented-runtime], - [force the usage of the instrumented runtime])]) - AC_ARG_ENABLE([cmm-invariants], [AS_HELP_STRING([--enable-cmm-invariants], [enable invariants checks in Cmm])]) @@ -1503,10 +1497,6 @@ AS_CASE([$host], ] ) -AS_IF([test "x$enable_force_instrumented_runtime" = "xyes"], - [force_instrumented_runtime=true] -) - # The instrumented runtime is built by default # if the proper clock source is found. # If asked via --enable-instrumented-runtime, configuration fails if the proper diff --git a/utils/clflags.ml b/utils/clflags.ml index 68200b715705..569358c96dc6 100644 --- a/utils/clflags.ml +++ b/utils/clflags.ml @@ -166,10 +166,7 @@ let pic_code = ref (match Config.architecture with (* -fPIC *) | "amd64" -> true | _ -> false) -let runtime_variant = - ref (match Config.force_instrumented_runtime with (* -runtime-variant *) - | true -> "i" - | false -> "") +let runtime_variant = ref "" let with_runtime = ref true (* -with-runtime *) diff --git a/utils/config.fixed.ml b/utils/config.fixed.ml index 141fcea3d875..e29c94cfe13e 100644 --- a/utils/config.fixed.ml +++ b/utils/config.fixed.ml @@ -47,7 +47,6 @@ let flambda = false let with_flambda_invariants = false let with_cmm_invariants = false let windows_unicode = false -let force_instrumented_runtime = false let flat_float_array = true let function_sections = false let afl_instrument = false diff --git a/utils/config.generated.ml.in b/utils/config.generated.ml.in index af25f2ca1dbc..38080890040c 100644 --- a/utils/config.generated.ml.in +++ b/utils/config.generated.ml.in @@ -78,7 +78,6 @@ let flambda = @flambda@ let with_flambda_invariants = @flambda_invariants@ let with_cmm_invariants = @cmm_invariants@ let windows_unicode = @windows_unicode@ != 0 -let force_instrumented_runtime = @force_instrumented_runtime@ let flat_float_array = @flat_float_array@ diff --git a/utils/config.mli b/utils/config.mli index c4333c055c72..fb0d7335091b 100644 --- a/utils/config.mli +++ b/utils/config.mli @@ -239,10 +239,6 @@ val supports_shared_libraries: bool @since 4.08 *) -val force_instrumented_runtime: bool -(** Force runtime-variant to be "i" at configure time - when ocamlc or ocamlopt link executables. *) - val afl_instrument : bool (** Whether afl-fuzz instrumentation is generated by default *)