E164 method US only #3
Comments
jaredmoody
added a commit
to Jetbuilt/twilio-verify-devise
that referenced
this issue
Apr 18, 2023
- Remove e164 formatting method from TwilioVerifyService, User#mobile_phone must be stored in -e164 format. - Note required format of mobile_phone column in README
|
Yeah i need to re-visit non US phone number support, I don't want to remove this method as this will introduce breaking changes for some apps. I planned to swap out the hardcoded US format with a more versatile e164 formatting ruby gem like hexorx/e164 |
jaredmoody
added a commit
to Jetbuilt/twilio-verify-devise
that referenced
this issue
Jun 3, 2024
- Remove e164 formatting method from TwilioVerifyService, User#mobile_phone must be stored in -e164 format. - Note required format of mobile_phone column in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TwilioVerifyService.e164_formatis a one-liner that provides very little value, but makes this plugin unusable for anyone outside the US.We have customers outside the US, so can't use this as-is.
How about just removing it and making a note in the README that the phone number provided needs to be validated to be in E164 format?
The text was updated successfully, but these errors were encountered: