Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport switch to prop-types package to the v1 branch to add compat with react 16 #75

Open
mgcrea opened this issue Sep 27, 2017 · 5 comments

Comments

@mgcrea
Copy link

mgcrea commented Sep 27, 2017

After updating to react 16, I encountered the following error:

TypeError: Cannot read property 'shape' of undefined
./node_modules/react-css-themr/lib/utils/themr-shape.js
node_modules/react-css-themr/lib/utils/themr-shape.js:7

Would be great to add a 1.8 release with the switch to the prop-types package to maintain compatibility for people like us stuck on toolbox v1 for now.

manuphatak added a commit to manuphatak/react-css-themr that referenced this issue Oct 13, 2017
@manuphatak
Copy link

Created a branch with this work. 1.7.2...bionikspoon:react_16

Tests are passing. I don't know your release process.

manuphatak added a commit to manuphatak/react-css-themr that referenced this issue Oct 13, 2017
@manuphatak
Copy link

published a built version: https://github.com/bionikspoon/react-css-themr/tree/react_16_build

This fork is working it's way into production on my team. Conversation here: react-toolbox/react-toolbox#1703

{
  "dependencies": {
    "react-css-themr": "git://github.com/bionikspoon/react-css-themr.git#react_16_build"
  }
}

@markusguenther
Copy link

Hi,

this is already into the master and the issue can be closed in favor of #83 I guess :)

see at commit:
b7fec0d

@dheeraja00
Copy link

@markusguenther I think this is not merged to master, in master I can still see older react version "react": "^15.5.4",

@markusguenther
Copy link

I meant the usage of proptype and so on ... see the file for instance in the master.

https://github.com/javivelasco/react-css-themr/blob/master/src/utils/themr-shape.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants