-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport switch to prop-types
package to the v1 branch to add compat with react 16
#75
Comments
Created a branch with this work. 1.7.2...bionikspoon:react_16 Tests are passing. I don't know your release process. |
published a built version: https://github.com/bionikspoon/react-css-themr/tree/react_16_build This fork is working it's way into production on my team. Conversation here: react-toolbox/react-toolbox#1703 {
"dependencies": {
"react-css-themr": "git://github.com/bionikspoon/react-css-themr.git#react_16_build"
}
} |
@markusguenther I think this is not merged to master, in master I can still see older react version |
I meant the usage of proptype and so on ... see the file for instance in the master. https://github.com/javivelasco/react-css-themr/blob/master/src/utils/themr-shape.js |
After updating to react 16, I encountered the following error:
Would be great to add a 1.8 release with the switch to the
prop-types
package to maintain compatibility for people like us stuck on toolbox v1 for now.The text was updated successfully, but these errors were encountered: