Fix mainview.c warning on gcc compilation #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Space after printf % character does make sense only when the value can be negative. If it is always positive, the space can be before the number in all cases. GCC warns about this, this change fixes it. This fixes following warning: mainview.c:596:38: warning: ' ' flag used with ‘%u’ gnu_printf format [-Wformat=] 596 | wprintw(miscview, "\nCycles :% 10u\n", clocks);
|
FYI: I have submitted Fedora package review with this project. It is tiny with almost no dependencies. Unlike Atanua it has no required data files without obvious license. I have not used 8051 for anything since school, but this little thing might be very useful to anyone actually trying to learn about processors. Thank you both for creating it and making it open source! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Space after printf % character does make sense only when the value can be negative. If it is always positive, the space can be before the number in all cases. GCC warns about this, this change fixes it.
This fixes following warning:
mainview.c:596:38: warning: ' ' flag used with ‘%u’ gnu_printf format [-Wformat=]
596 | wprintw(miscview, "\nCycles :% 10u\n", clocks);