Refactoring the bit addressing opcodes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with C99 fixed size types. Given the C integer arithmetic rules it isn't even required
This refactors the bit accesses. Again it gains in readability.
steveschnepp
force-pushed
the
refactor-bitaddr
branch
from
8482664
to
6284fc0
Compare
|
Did you have time to review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the bit accesses.
Again it gains in readability.
I moved every function in its own commit, as I had some bugs and elementary commits helped
git bisecting, which was made neat with some rebase.I let the fix commits in, as I learned about it and so can anyone reading the history via
git blame. Thoseboolbehavior are still a little arcane to me. Using them naively works perfectly, but casting them tointas 0 and 1 doesn't always.I also fixed some minor timings