Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs on OAuth2Strategy({ scope, scopeSeperator }) #91

Open
blaskovicz opened this issue Sep 28, 2017 · 3 comments · May be fixed by #93
Open

Add Docs on OAuth2Strategy({ scope, scopeSeperator }) #91

blaskovicz opened this issue Sep 28, 2017 · 3 comments · May be fixed by #93

Comments

@blaskovicz
Copy link

Please add docs on the utilization of scope and scopeSeperator for the new OAuth2Strategy(options) constructor.

https://github.com/jaredhanson/passport-oauth2/blob/master/lib/strategy.js#L95
https://github.com/jaredhanson/passport-oauth2/blob/master/lib/strategy.js#L96

dan-nl added a commit to dan-nl/passport-oauth2 that referenced this issue Oct 27, 2017
@dan-nl dan-nl linked a pull request Oct 27, 2017 that will close this issue
dan-nl added a commit to dan-nl/passport-oauth2 that referenced this issue Oct 27, 2017
dan-nl added a commit to dan-nl/passport-oauth2 that referenced this issue Oct 27, 2017
dan-nl added a commit to dan-nl/passport-oauth2 that referenced this issue Oct 27, 2017
dan-nl added a commit to dan-nl/passport-oauth2 that referenced this issue Oct 27, 2017
dan-nl added a commit to dan-nl/passport-oauth2 that referenced this issue Oct 27, 2017
@abelosorio
Copy link

abelosorio commented Oct 22, 2018

@dan-nl your commits include these docs. Are you planning to create a PR? or have you already?

Thanks

@dan-nl
Copy link

dan-nl commented Oct 26, 2018

@abelosorio, the pr already exists, pr #93, but hasn’t been merged into this project yet. it looks like this repo no longer has an active maintainer.

@abelosorio
Copy link

abelosorio commented Oct 26, 2018

That's too bad @dan-nl I think this repo is very used yet.

@jaredhanson is there anything I can help with? Or is there any reason why you decided to terminate this repo's maintenance?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants