From 5403a6ed07bbec2b77c18a781f359de5d1c44b05 Mon Sep 17 00:00:00 2001 From: Edgar Gabriel Date: Tue, 26 Sep 2023 02:29:41 -0500 Subject: [PATCH] TEST: use gcc to compile UCX in clang-tidy-rocm (#846) The hip header file generates a warning when compiled with clang, which in itself is harmless, but because all warnings are treated as errors, the compilation fails in the UCX step. Compile UCX with gcc instead of clang (since we are not truly interested in running clang-tidy on ucx in this CI, but just on UCC) Furthermore, force using rocm 5.6.1 instead of the newest version --- .github/workflows/clang-tidy-rocm.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/clang-tidy-rocm.yaml b/.github/workflows/clang-tidy-rocm.yaml index 2842967bb9..f137ed1184 100644 --- a/.github/workflows/clang-tidy-rocm.yaml +++ b/.github/workflows/clang-tidy-rocm.yaml @@ -6,7 +6,7 @@ env: OPEN_UCX_LINK: https://github.com/openucx/ucx OPEN_UCX_BRANCH: master CLANG_VER: 12 - ROCM_VER: 5-4 + ROCM_VER: 5.6.1 LIBRARY_PATH: /tmp/ucx/install/lib LD_LIBRARY_PATH: /tmp/ucx/install/lib jobs: @@ -23,7 +23,7 @@ jobs: - name: Install extra dependencies run: | curl -fsSL https://repo.radeon.com/rocm/rocm.gpg.key | sudo gpg --dearmor -o /etc/apt/trusted.gpg.d/rocm-keyring.gpg - echo 'deb [arch=amd64 signed-by=/etc/apt/trusted.gpg.d/rocm-keyring.gpg] https://repo.radeon.com/rocm/apt/debian focal main' | sudo tee /etc/apt/sources.list.d/rocm.list + echo 'deb [arch=amd64 signed-by=/etc/apt/trusted.gpg.d/rocm-keyring.gpg] https://repo.radeon.com/rocm/apt/5.6.1 focal main' | sudo tee /etc/apt/sources.list.d/rocm.list sudo apt-get update sudo apt-get install -y rocm-hip-sdk - name: Get UCX @@ -31,7 +31,7 @@ jobs: - name: Build UCX run: | cd /tmp/ucx && ./autogen.sh - CC=clang-${CLANG_VER} CXX=clang++-${CLANG_VER} ./contrib/configure-release --without-java --without-go --disable-numa --prefix $PWD/install --with-rocm=/opt/rocm + CC=gcc CXX=g++ ./contrib/configure-release --without-java --without-go --disable-numa --prefix $PWD/install --with-rocm=/opt/rocm make -j install - uses: actions/checkout@v1 - name: Build UCC