Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loader when starting model #945

Merged
merged 3 commits into from
Dec 14, 2023
Merged

feat: loader when starting model #945

merged 3 commits into from
Dec 14, 2023

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 11, 2023

fix #873

Screenshot 2023-12-11 at 22 37 15

@urmauur urmauur added the type: feature request A new feature label Dec 11, 2023
@urmauur urmauur requested a review from louis-jan December 11, 2023 15:40
@urmauur urmauur self-assigned this Dec 11, 2023
@urmauur urmauur requested a review from namchuai December 11, 2023 15:40
@namchuai
Copy link
Contributor

One thought, why don't we separate the loading into another component? Putting the state in Chat screen component makes things re-render unnecessarily.

@urmauur urmauur force-pushed the feat/loader-model-active branch from 4c0e910 to b57f6ef Compare December 14, 2023 06:32
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Thank you!

@urmauur urmauur merged commit 01939af into main Dec 14, 2023
3 checks passed
@urmauur urmauur deleted the feat/loader-model-active branch December 14, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: "Fake" loading for model starting
2 participants