Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memory leak lowlight dependencies #4134

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: memory leak lowlight dependencies #4134

merged 1 commit into from
Nov 27, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Nov 26, 2024

Describe Your Changes

Downgrade rehype-highlight due to issue lowlight performance

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Nov 26, 2024
@urmauur urmauur added this to the v0.5.10 milestone Nov 26, 2024
@urmauur urmauur requested a review from louis-jan November 26, 2024 18:19
@urmauur urmauur self-assigned this Nov 26, 2024
@urmauur
Copy link
Member Author

urmauur commented Nov 26, 2024

feat build: https://github.com/janhq/jan/actions/runs/12036684293

@github-actions GitHub Actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.14%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/screens/Thread/ThreadCenterPanel/SimpleTextMessage/index.tsx51-55, 57-58, 61, 64, 72-75, 77, 81, 88-90, 96, 100-103, 108-109, 112, 162, 164-165, 170-171, 230, 235-239, 241-243, 245-246, 248-250, 253-255, 257-258, 333, 356

@louis-jan louis-jan merged commit bff0a3a into dev Nov 27, 2024
21 checks passed
@louis-jan louis-jan deleted the fix/memory-leak-performance branch November 27, 2024 02:02
@louis-jan
Copy link
Contributor

Update: Latex is broken

@louis-jan louis-jan restored the fix/memory-leak-performance branch November 27, 2024 02:38
@louis-jan louis-jan mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.5.10
Development

Successfully merging this pull request may close these issues.

bug: White screen issues [Memory Leak]
2 participants
@urmauur @louis-jan