Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped MSVC support #3

Open
jonahbeckford opened this issue Jan 14, 2023 · 1 comment
Open

Dropped MSVC support #3

jonahbeckford opened this issue Jan 14, 2023 · 1 comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@jonahbeckford
Copy link

There was commit 3d2ce1b that supported the MSVC compiler. But it got removed.

As a temporary hack, for Windows users of Diskuv OCaml (DKML) I've patched this package in the DKML opam repository.
jonahbeckford added a commit to diskuv/diskuv-opam-repository that referenced this issue Jan 14, 2023
@jonahbeckford
Add back in MSVC C code
41092f0 
* Temporary patch for janestreet/time_now#3
@jonahbeckford
Copy link
Author

jonahbeckford commented Jan 14, 2023 •
edited
Loading

One related MSVC note. During the build I get:

cl : Command line warning D9002 : ignoring unknown option '-std=c11'
cl : Command line warning D9002 : ignoring unknown option '-fPIC'

I am using MSVC 2019, where it just warns but does not fail the compilation. Often newer versions of MSVC will fail when a warning has been repeated long enough.

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@github-iron @jonahbeckford