From 923eaef28ea563096241c01031e8b3961f181308 Mon Sep 17 00:00:00 2001 From: Clark Gaebel Date: Sun, 7 Aug 2022 12:03:31 -0400 Subject: [PATCH] Disable dlfilter by default Per #246, I think it's busted right now in the face of trace errors. Lets turn it off by default until we ship a solution. --- core/env_vars.ml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/env_vars.ml b/core/env_vars.ml index 2c368c658..fb7ff942d 100644 --- a/core/env_vars.ml +++ b/core/env_vars.ml @@ -21,8 +21,10 @@ let debug = Option.is_some (Unix.getenv "MAGIC_TRACE_DEBUG") features of magic-trace. *) let experimental = Option.is_some (Unix.getenv "MAGIC_TRACE_EXPERIMENTAL") -(* When tracing the kernel on certain systems, perf only has root access when +(* magic-trace's dlfilter integration is busted right now, see #246. Also: + + When tracing the kernel on certain systems, perf only has root access when being run with a specific set of flags. Since this does not include [--dlfilter], this environment variable allows the user to forcibly disable filtering. *) -let no_dlfilter = Option.is_some (Unix.getenv "MAGIC_TRACE_NO_DLFILTER") +let no_dlfilter = Option.is_none (Unix.getenv "MAGIC_TRACE_ENABLE_DLFILTER")