Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set_intf change #172

Open
tianboh opened this issue Oct 12, 2024 · 0 comments
Open

Set_intf change #172

tianboh opened this issue Oct 12, 2024 · 0 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@tianboh
Copy link

tianboh commented Oct 12, 2024

Hi there, my project used Core 0.14 before, and I am updating it to 0.17 recently. However, it seems that Set_intf changed. There was a union function for set derived from Set.Make(), but its gone now. Check this simple snippet

#use "topfind";;
#require "core";;
open Core;;
module IntSet = Set.Make(Int);;
let a = IntSet.of_list [1] in
let b = IntSet.of_list [2] in
let c = IntSet.union a b in
c;;

It pops

File "file.ml", line 7, characters 8-20:
7 | let c = IntSet.union a b in
            ^^^^^^^^^^^^
Error: Unbound value IntSet.union

I am curious why removing union function, it seems a quite common function for any derived set. I posted a similar topic in ocaml forum, but I guess I can get more details and ideas from development team here :-)

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

2 participants