Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Android Build OS #3444

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Dec 23, 2024

Short description of changes

This will upgrade the OS of the Android runner to support the latest aqt version.

CHANGELOG: Upgrade Android Runner to Ubuntu 22.04

Context: Fixes an issue?

Related to: #3434

Does this change need documentation? What needs to be documented and how?

/

Status of this Pull Request

Ready for review.

What is missing until this pull request can be merged?

Review

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors. (iOS failure is expected)
  • I've filled all the content above

@ann0see ann0see added the android Android runtime issue label Dec 23, 2024
@ann0see ann0see added this to the Release 3.12.0 milestone Dec 23, 2024
@pljones
Copy link
Collaborator

pljones commented Dec 23, 2024

What does this actually affect? Changing the host OS on which the Android build is run should not change anything -- unless it's not just the host OS that's changing. Is the Android build changing in some other way - e.g. supported Android tools, minimum versions, etc, changes in Qt support? (Yes, it's draft -- just ideas to get into the description before it's ready.)

@ann0see
Copy link
Member Author

ann0see commented Dec 23, 2024

It's for potentially fixing #3434 not finding the latest aqt.

@ann0see
Copy link
Member Author

ann0see commented Dec 23, 2024

Ok. Tested on Bliss OS. And the app opens. Can't really test more though.

@ann0see
Copy link
Member Author

ann0see commented Dec 23, 2024

Ok. Seems as if the aqt update will work with the OS upgrade: https://github.com/jamulussoftware/jamulus/actions/runs/12473251295/job/34813435081

@ann0see ann0see force-pushed the upgradeAndroidBuildOS branch from 3d11110 to 0b4a600 Compare December 23, 2024 21:39
@ann0see ann0see marked this pull request as ready for review December 23, 2024 21:43
@ann0see ann0see requested review from softins and pljones December 23, 2024 22:06
@pljones
Copy link
Collaborator

pljones commented Dec 24, 2024

OK, might as well just get it merged, then?

@pljones pljones merged commit bd6adea into jamulussoftware:main Dec 25, 2024
21 of 23 checks passed
@ann0see ann0see deleted the upgradeAndroidBuildOS branch December 25, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android runtime issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants