Target Android 14 (SDK 34) #3437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes jamulussoftware#3261 - Update Android build to support QT6 - Update Android build to use latest dependencies supported by QT 6.7.2
|
Cool. Thank you very much! |
ann0see
reviewed
Dec 10, 2024
| @@ -40,7 +40,7 @@ | |||
| #endif | |||
| #include "util.h" | |||
| #ifdef ANDROID | |||
| # include <QtAndroidExtras/QtAndroid> | |||
| # include <QtCore/private/qandroidextras_p.h> | |||
There was a problem hiding this comment.
Does this break the qt5 build?
Is using "private" the best the way?
|
The CI fails. |
|
Can I propose we close this as encompassed by #3392, which we'll take into Jamulus 4? |
I would have no issue with that |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Update Android build to support Android 14.
CHANGELOG: Update Android build to support QT6 and latest dependencies supported by QT 6.7.2
Context: Fixes an issue?
Fixes #3261
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist
AUTOBUILD: Please build all targets