-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up DISTFILES #3346
Clean up DISTFILES #3346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, I forgot about that reference. Good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, make dist
throws up some other errors too, which are probably additional obsolete filenames:
cp: cannot stat 'src/res/CLEDBlack.png': No such file or directory
cp: cannot stat 'src/res/CLEDDisabledSmall.png': No such file or directory
cp: cannot stat 'src/res/CLEDGreen.png': No such file or directory
cp: cannot stat 'src/res/CLEDGreySmall.png': No such file or directory
cp: cannot stat 'src/res/CLEDRed.png': No such file or directory
cp: cannot stat 'src/res/CLEDYellow.png': No such file or directory
cp: cannot stat 'src/res/LEDBlackSmall.png': No such file or directory
cp: cannot stat 'src/res/LEDGreenSmall.png': No such file or directory
cp: cannot stat 'src/res/LEDRedSmall.png': No such file or directory
cp: cannot stat 'src/res/LEDYellowSmall.png': No such file or directory
cp: cannot stat 'src/res/HLEDGreenSmall.png': No such file or directory
cp: cannot stat 'src/res/HLEDBlackSmall.png': No such file or directory
cp: cannot stat 'src/res/HLEDRedSmall.png': No such file or directory
cp: cannot stat 'src/res/HLEDYellowSmall.png': No such file or directory
cp: cannot stat 'libs/opus/INSTALL': No such file or directory
make[1]: *** [Makefile.Release:1163: distdir] Error 1
make[1]: Leaving directory '/home/tony/jamulus'
make: *** [Makefile:299: release-distdir] Error 2
Looks like at least some of them date from 7e75842. I'll check the list from scratch. |
Remove refrences to files that no longer exist. Add new resource files that were missing from the list.
I've pushed an update that removes obsolete filenames from the list and adds some that were missing. We should update the PR title/description to reflect the wider scope of the changes. |
Thanks. |
Why is this 3.12.0 and not 3.11.0? Given that it's fixing something that's incorrect, and doesn't affect the application code or translations. |
We're just conservative on tagging things after freeze. |
Anyway, retagged |
Short description of changes
Removes and adds references to removed/moved files in Jamulus.pro
CHANGELOG: SKIP
Context: Fixes an issue?
Fixes: #3345
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
make dist
was tested by @softinsWhat is missing until this pull request can be merged?
Review
Checklist