Update CONTRIBUTING.md for min Qt version #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Updates CONTRIBUTING.md for the minimum Qt version. Plus minor formatting and extended comment on checking builds and on new dependencies.
On a side note: I was wondering if we should note that Qt5 is no longer "officially supported" by Qt... The online installer no longer offers it at all (we really need to move everything to Qt6, I just wish it was better at cross-platform visual support.) The closest I can find is
https://launchpad.net/~beineri/+archive/ubuntu/opt-qt-5.12.2-bionic
for Ubuntu -- I guess someone will be packaging it still for Debian (Qt5.12 on Deb 10 RPi versions appear in demand).
CHANGELOG: SKIP
Context: Fixes an issue?
Fixes 3322
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review
Checklist