Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IAsyncDisposable + upgrade most projects to .net 6.0 #331

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

jamesmh
Copy link
Owner

@jamesmh jamesmh commented Mar 24, 2023

This has alot of changes. Essentially there are two main goals of this PR:

  • Introduce usage of IAsyncDisposable
  • Because 👆 is only supported in .net 6 (well, via Microsoft.Extensions.DependencyInjection Version=6.0.0+) then I upgraded all the projects to .net 5.0 and coravel is using Microsoft.Extensions.DependencyInjection version 6.

No packages have been released yet as of this PR.

@jamesmh jamesmh self-assigned this Mar 24, 2023
@jamesmh jamesmh changed the title Implement IAsyncDisposable + upgrade most projects to .net 5.0 Implement IAsyncDisposable + upgrade most projects to .net 6.0 Mar 24, 2023
@jamesmh
Copy link
Owner Author

jamesmh commented Aug 17, 2023

Currently upgraded everything to .NET 6 and will test prerelease packages with sample projects before considering this a success and publishing release versions.

@jamesmh
Copy link
Owner Author

jamesmh commented Aug 18, 2023

Tested Coravel, Mailer and CLI in a test project locally using .NET 6, .NET 7 and .NET 8 preview with success. Will move to publish release versions.

@jamesmh jamesmh merged commit cba14ee into master Aug 18, 2023
4 checks passed
@jamesmh jamesmh deleted the upgrade-to-dotnet5 branch August 18, 2023 01:18
@jamesmh
Copy link
Owner Author

jamesmh commented Aug 18, 2023

Released

  • Coravel 5.0.0
  • Coravel.Mailer 5.0.0
  • Coravel.Cli 1.0.0

Addresses #302 #328 #288 (possibly #282)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant