This repository has been archived by the owner on Jan 11, 2020. It is now read-only.
Get the properties of the setup WiFi AP #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirk007
reviewed
Mar 13, 2018
Basecamp.cpp
Outdated
| * Returns the SSID of the setup WiFi network | ||
| */ | ||
| String Basecamp::getSetupModeWifiName(){ | ||
| return "ESP32_" + wifi.getHardwareMacAddress(); |
There was a problem hiding this comment.
To have a single source of truth, I would suggest to implement a wifi.getApName()-Getter in the wifiControl and return the info from there right here using return wifi.getApName().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces three new functions for easier handling of the setup WiFi network:
bool isSetupModeWifiEncrypted(): Returns true if the WiFi is encryptedString getSetupModeWifiName(): Returns the SSID of the setup WiFi (ESP32_)String getSetupModeWifiSecret(): Returns the secret of the setupt WiFiThis PR is required to fix jamct/DoorsignEPD#19