Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Es6 Is not supporet #245

Open
timsar2 opened this issue Dec 8, 2022 · 2 comments
Open

Es6 Is not supporet #245

timsar2 opened this issue Dec 8, 2022 · 2 comments

Comments

@timsar2
Copy link

timsar2 commented Dec 8, 2022 •
edited
Loading

Es6 is not supported. this package is dependent on CommonJS or AMD.
that can cause optimization bailouts when bundling modern javascript.
https://web.dev/commonjs-larger-bundles/
@behrang
Copy link
Member

behrang commented Jan 8, 2023

You're right, but what's your proposal? I think this project is getting retired and it's better to not make a big change like this.

@HoseinGhanbari
Copy link

It would be great if we can upgrade the package in order to make it compatible with modern javascript. According to angular.io It is recommended that you avoid depending on CommonJS modules in your Angular applications as

CommonJS or AMD dependencies can cause optimization bailouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@behrang @timsar2 @HoseinGhanbari