Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm PHPUnit plugin #99

Closed
dkarlovi opened this issue May 21, 2019 · 5 comments
Closed

Psalm PHPUnit plugin #99

dkarlovi opened this issue May 21, 2019 · 5 comments
Labels
good first issue Good for newcomers

Comments

@dkarlovi
Copy link
Contributor

https://github.com/psalm/phpunit-psalm-plugin

@ro0NL
Copy link
Contributor

ro0NL commented Jun 16, 2019

As of PHPUnit 8 is it still needed? Asking, since psalm-annotations are built-in upstream now: https://github.com/sebastianbergmann/phpunit/blob/0d5379adebbfde18710b076acc9550eb6a328b48/src/Framework/TestCase.php#L1087-L1091

@dkarlovi
Copy link
Contributor Author

@ro0NL fair point, might be worth it if you're using something which can't use > 7 (BC breaks, IIRC).

@ro0NL
Copy link
Contributor

ro0NL commented Jun 17, 2019

long-term i think the ecosystem is better of withh built-in (psalm) types upstream; not having more plugins 😅 Though agree this might be needed meanwhile.

Same for #105 , i believe @Ocramius is a on a mission a add types to Doctrine upstream, but im not sure it'll target 2.x.

@dkarlovi
Copy link
Contributor Author

Yes, but again, the plugin is available now to current codebases, no reason not to include it. It's easy enough to remove both of them later when they're no longer needed (and probably not maintained).

@dkarlovi
Copy link
Contributor Author

Done in #252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants