Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE enhancements #124

Closed
18 of 24 tasks
Kampi opened this issue Nov 19, 2023 · 7 comments · Fixed by #172
Closed
18 of 24 tasks

BLE enhancements #124

Kampi opened this issue Nov 19, 2023 · 7 comments · Fixed by #172
Assignees
Labels
BLE Bluetooth related enhancement New feature or request GUI LVGL/UI Related

Comments

@Kampi
Copy link
Collaborator

Kampi commented Nov 19, 2023

Collection of different BLE topics

ToDo

Open issues with notifications

  • Crashing when leaving the notifications list when a notification is available
  • Longer notifications the body can't be seen (I guess LVGL scrolls to the bottom or something)
  • Sometimes the age of notification shows a huge number
  • Easy to accidentally remove the notification when scrolling it
  • Convert the age into a nice time format
  • Scrolling of the body field is strange
  • Sometimes the body field will be focused
  • Scrolling the notification list can be a little bit weird. I guess because of the scrolling body field. Need to check it in detail
  • Hide notification popup when the app is open. Here we should think about an API to get the app status
  • Notification is not 100% centered
  • Scroll one
  • Notification removal on the phone doesn´t work
  • Support for YouTube notifications
  • Support for WhatsApp notificaitons
@Kampi Kampi added enhancement New feature or request BLE Bluetooth related labels Nov 19, 2023
@Kampi Kampi self-assigned this Nov 19, 2023
@Kampi Kampi changed the title Rework pairing BLE enhancement Nov 20, 2023
@Kampi Kampi changed the title BLE enhancement BLE enhancements Nov 20, 2023
@Kampi Kampi linked a pull request Nov 20, 2023 that will close this issue
@Kampi Kampi reopened this Nov 20, 2023
@Kampi Kampi removed a link to a pull request Nov 20, 2023
@Kampi
Copy link
Collaborator Author

Kampi commented Nov 21, 2023

@ldab

I split the Gadgetbridge related code up into a separate source file.

https://github.com/jakkra/ZSWatch/tree/BLE_enhancements%23124

@ldab
Copy link
Collaborator

ldab commented Nov 21, 2023

Will check the PR tomorrow 👊

@Kampi Kampi added the GUI LVGL/UI Related label Nov 23, 2023
@Kampi
Copy link
Collaborator Author

Kampi commented Nov 25, 2023

We are changing the communication flow for notifications to this
image

This allows us to create and push internal notifications to the notification manager. The notification manager is the main instance in handling all notifications.

@jakkra @ldab
I pushed the latest version of the notification rework. Feel free to test this version and give some feedback :)
Not 100% nice now, but it´s working.

Changes so far

  • New layout
  • Different icons and titles for WhatsApp, Mail, etc.
  • Title and body field
  • Scrollable body (not sure if I will keep it)
  • Age of the notification
  • Scrolling improvement
  • Notifications will be added to the notification app when the app is open

Known issues

  • Convert the age into a nice time format
  • Scrolling of the body field is strange
  • Sometimes the body field will be focused
  • Scrolling the notification list can be a little bit weird. I guess because of the scrolling body field. Need to check it in detail
  • Hide notification popup when the app is open. Here we should think about an API to get the app status
  • Notification is not 100% centered

image

@ldab
Copy link
Collaborator

ldab commented Nov 25, 2023

The latest commit does not seem to build on CI, I haven’t looked as why, but is this ready to feedback?

@Kampi
Copy link
Collaborator Author

Kampi commented Nov 25, 2023

@ldab the build fails because of the style. I haven´t added astyle to VS Code yet, so I must do it before a commit and I normally do it before a PR.

@jakkra
Copy link
Owner

jakkra commented Nov 25, 2023

@Kampi Running it today!
Some quick things:

  • Send some notfications

    • Enter notification list
    • Exist -> crash
  • Longer notifications the body can't be seen (I guess LVGL scrolls to bottom or something)

  • Sometimes the age of notification shows a huge number

  • Easy to accidentally remove the notification when scrolling it

@Kampi
Copy link
Collaborator Author

Kampi commented Nov 25, 2023

  • Enter notification list
    • Exist -> crash
  • Easy to accidentally remove the notification when scrolling it

@jakkra fixed :)

@Kampi Kampi linked a pull request Nov 26, 2023 that will close this issue
@Kampi Kampi linked a pull request Nov 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE Bluetooth related enhancement New feature or request GUI LVGL/UI Related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants