Skip to content
This repository has been archived by the owner on Apr 3, 2018. It is now read-only.

Unable to use Sort by Order for a custom post type and taxonomy #6

Open
dylanjameswagner opened this issue Aug 19, 2015 · 2 comments
Open

Comments

@dylanjameswagner
Copy link

In the admin. When viewing a custom post type list by taxonomy the Sort by Order link is invalid, it includes an encoded ampersand, outputting #038; where an ampersand should be.

I believe the issue can be traced to line 284 of simple-page-ordering.php. There is a remove_query_arg wrapped by esc_url which I believe is encoding a trailing ampersand once the orderby and order have been removed.

I am able to restore expected functionality by removing the esc_url, but I am unsure of the security issues with doing so.

@timiwahalahti
Copy link

Just made a PR #10 fixing this issue :)

@helen
Copy link

helen commented Apr 2, 2018

I believe this should be fixed in the latest .org release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants