diff --git a/api/src/main/java/jakarta/servlet/ReadListener.java b/api/src/main/java/jakarta/servlet/ReadListener.java index 758be6c74..bdfba146e 100644 --- a/api/src/main/java/jakarta/servlet/ReadListener.java +++ b/api/src/main/java/jakarta/servlet/ReadListener.java @@ -48,7 +48,19 @@ public interface ReadListener extends EventListener { public void onAllDataRead() throws IOException; /** - * Invoked when an error occurs processing the request. + * Invoked when an error occurs reading data. This listener will be invoked if there is a problem with the + * underlying connection while data is being read from the stream. We consider data to be being read when the following + * conditions are met: + * + *
+ * If an error occurs and {@link ReadListener#onError(Throwable)} is invoked then this method will always return + * false, as no further IO operations are allowed after {@code onError} notification. + *
+ * Note that due to the requirement for {@code read} to never throw in async mode, this method must return false
+ * if a call to {@code read} would result in an exception.
+ *
* @return true
if data can be obtained without blocking, otherwise returns false
.
*
* @since Servlet 3.1
@@ -108,7 +117,13 @@ public int readLine(byte[] b, int off, int len) throws IOException {
public abstract boolean isReady();
/**
- * Instructs the ServletInputStream
to invoke the provided {@link ReadListener} when it is possible to read
+ * Instructs the ServletInputStream
to invoke the provided {@link ReadListener} when it is possible to read.
+ *
+ * Note that after this method has been called methods on this stream that are documented to throw {@link IOException} will + * no longer throw these exceptions directly, instead any exception that occurs will be reported via + * {@link ReadListener#onError(Throwable)}. Please refer to this method for more information. This only applies to + * {@code IOException}, other exception types may still be thrown (e.g. methods can throw {@link IllegalStateException} + * if {@link #isReady()} has not returned true). * * @param readListener the {@link ReadListener} that should be notified when it's possible to read. * diff --git a/api/src/main/java/jakarta/servlet/ServletOutputStream.java b/api/src/main/java/jakarta/servlet/ServletOutputStream.java index e97328f01..1315ca2ce 100644 --- a/api/src/main/java/jakarta/servlet/ServletOutputStream.java +++ b/api/src/main/java/jakarta/servlet/ServletOutputStream.java @@ -273,6 +273,15 @@ public void println(double d) throws IOException { /** * This method can be used to determine if data can be written without blocking. + *
+ * If an attempt is made to write to the stream when the stream is in async mode and this method has not returned + * {@code true} the method will throw an {@link IllegalStateException}. + *
+ * If an error occurs and {@link WriteListener#onError(Throwable)} is invoked then this method will always return + * false, as no further IO operations are allowed after {@code onError} notification. + *
+ * Note that due to the requirement for {@code write} to never throw in async mode, this method must return false
+ * if a call to {@code write} would result in an exception.
*
* @return true
if a write to this ServletOutputStream
will succeed, otherwise returns
* false
.
@@ -283,8 +292,17 @@ public void println(double d) throws IOException {
/**
* Instructs the ServletOutputStream
to invoke the provided {@link WriteListener} when it is possible to
- * write
- *
+ * write.
+ *
+ * Note that after this method has been called methods on this stream that are documented to throw {@link IOException} will + * no longer throw these exceptions directly, instead any exception that occurs will be reported via + * {@link WriteListener#onError(Throwable)}. Please refer to this method for more information. This only applies to + * {@code IOException}, other exception types may still be thrown (e.g. methods can throw {@link IllegalStateException} + * if {@link #isReady()} has not returned true). + *
+ * Once this method has been called {@link #flush()} and {@link #close()} become asynchronous operations, they will be + * performed in the background and any problems will be reported through the {@link WriteListener#onError(Throwable)} + * method. * * @param writeListener the {@link WriteListener} that should be notified when it's possible to write * diff --git a/api/src/main/java/jakarta/servlet/WriteListener.java b/api/src/main/java/jakarta/servlet/WriteListener.java index be95242f5..8ae9ed8b8 100644 --- a/api/src/main/java/jakarta/servlet/WriteListener.java +++ b/api/src/main/java/jakarta/servlet/WriteListener.java @@ -39,7 +39,19 @@ public interface WriteListener extends EventListener { public void onWritePossible() throws IOException; /** - * Invoked when an error occurs writing data using the non-blocking APIs. + * Invoked when an error occurs writing data using the non-blocking APIs. This listener will be invoked if there is + * a problem with the underlying connection while data is being written to the stream. We consider data to be being + * written when any of the following conditions are met: + * + *