-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo images to make them editable (ie. svg) #214
Comments
Specific images that need to be recreated... Can do the others to be complete, but these definitely need updating for Jakarta EE 9... Let's first recreate them as they currently exist, and then use a separate PR for updating them.
|
I will try make this, but only at Saturday I can do it in my free time. May you wait until there? |
Absolutely we can wait. These are not for the Milestone, so we have some time before they are "due". Looking forward to what you can re-create. Thanks. |
@kwsutter which folder should I put the images? I make the bigger one and take a lot of time, I will work on the second still today. Maybe today I'll send the two images. |
The commit with images are ready. |
I have been following this ticket because it brings Contributions to the project without signing any agreements. Love it, you Samuel are worthy of emulation as so are you facilitator Kevin :) |
Oh, thanks! I like of opensource and this is the first time that I used inkscape to contribute with some project :) |
wow, that is amazing Samuel! Thanks for sharing that. https://www.eclipse.org/lists/jakarta.ee-community/msg02313.html |
@aeiras I will read that at Saturday, because I'm working now, but, I pretend to redo some others images to svg. |
Awesome work Samuel! Perhaps you would also take a look at the Jakarta EE
tutorial images? There are some old graphics there also but we never found
someone that could take care of them.
El jue., 25 jun. 2020 20:53, Samuel Leonardo <[email protected]>
escribió:
… @aeiras <https://github.com/aeiras> I will read that at Saturday, because
I'm working now, but, I pretend to redo some others images to svg.
It's a little weird for me contributing with graphics being a programmer
hahaha
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#214 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQC44CSNNNSNWG557M4MDLRYOMLHANCNFSM4OAXYSHA>
.
|
@ggam sorry for delay to answer. Could you say me where that images are located? At saturday, I will evaluate and estimate the time to do it. |
But you only took 3 hours to respond haha!!
Images are located at
https://github.com/eclipse-ee4j/jakartaee-tutorial/tree/master/src/main/jbake/assets/img
There are quite a bunch of images (~65) but there's no hurry for getting it
completed. Even if you submit a draft PR with only a few of them, it would
be a great start. I made most of the work to refresh the Tutorial look and
feel (see eclipse-ee4j/jakartaee-tutorial#191) but
we need to convert all the images before officially promoting it.
El vie., 26 jun. 2020 2:12, Samuel Leonardo <[email protected]>
escribió:
… @ggam <https://github.com/ggam> sorry for delay to answer. Could you say
me where that images are located? At saturday, I will evaluate and estimate
the time to do it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#214 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQC44FYPZCESH7AZUANDBDRYPRWPANCNFSM4OAXYSHA>
.
|
While updating the Platform spec for Milestone 1 of Jakarta EE 9, we determined that many of the images used in the spec need to be edited. Unfortunately, the current png format is not suitable for easy editing. We started to experiment using the two diagrams in the Deployment chapter. We used inkscape to recreate the images in svg format. Although it took a little bit of work to recreate them, they are now quite easy to update going forward.
We need to do this with the rest of the images in the Platform spec. This was documented as a comment in this Specifications PR: jakartaee/specifications#180 (comment)
The text was updated successfully, but these errors were encountered: