Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo images to make them editable (ie. svg) #214

Closed
kwsutter opened this issue Jun 17, 2020 · 14 comments
Closed

Redo images to make them editable (ie. svg) #214

kwsutter opened this issue Jun 17, 2020 · 14 comments

Comments

@kwsutter
Copy link
Contributor

kwsutter commented Jun 17, 2020

While updating the Platform spec for Milestone 1 of Jakarta EE 9, we determined that many of the images used in the spec need to be edited. Unfortunately, the current png format is not suitable for easy editing. We started to experiment using the two diagrams in the Deployment chapter. We used inkscape to recreate the images in svg format. Although it took a little bit of work to recreate them, they are now quite easy to update going forward.

We need to do this with the rest of the images in the Platform spec. This was documented as a comment in this Specifications PR: jakartaee/specifications#180 (comment)

@kwsutter
Copy link
Contributor Author

kwsutter commented Jun 17, 2020

Specific images that need to be recreated... Can do the others to be complete, but these definitely need updating for Jakarta EE 9... Let's first recreate them as they currently exist, and then use a separate PR for updating them.

  • JavaEEarchitecture.png
  • JavaEEinteroperability.png

@ghost
Copy link

ghost commented Jun 17, 2020

I will try make this, but only at Saturday I can do it in my free time. May you wait until there?

@kwsutter
Copy link
Contributor Author

I will try make this, but only at Saturday I can do it in my free time. May you wait until there?

Absolutely we can wait. These are not for the Milestone, so we have some time before they are "due". Looking forward to what you can re-create. Thanks.

@ghost
Copy link

ghost commented Jun 20, 2020

@kwsutter which folder should I put the images? I make the bigger one and take a lot of time, I will work on the second still today. Maybe today I'll send the two images.
UPDATE: the images are ready, tomorrow I will send, now I'm going to sleep.

@ghost
Copy link

ghost commented Jun 23, 2020

The commit with images are ready.

@kwsutter
Copy link
Contributor Author

I just approved and merged PR #217. Thanks, @cpusam, for redo-ing these images. They look great.

@aeiras
Copy link

aeiras commented Jun 25, 2020

I have been following this ticket because it brings Contributions to the project without signing any agreements.
It is formidably fun to see Jakartee Samuel @cpusam contribute without red-tape and use write up authorization to submit designs.

Love it, you Samuel are worthy of emulation as so are you facilitator Kevin :)

@ghost
Copy link

ghost commented Jun 25, 2020

@aeiras

Love it, you Samuel are worthy of emulation as so are you facilitator Kevin :)

Oh, thanks! I like of opensource and this is the first time that I used inkscape to contribute with some project :)

@aeiras
Copy link

aeiras commented Jun 25, 2020

wow, that is amazing Samuel!

Thanks for sharing that.
Without pressure, please check out the doodle poll open for the Friends of Jakarta zoom call using this thread and if able, participate and join that call. I believe that Jakarta EE benefit from Contributors like you! :) stay safe and hope to continue to learn more about what you care to contribute to and the clever forms you own such contributions. Cheers

https://www.eclipse.org/lists/jakarta.ee-community/msg02313.html

@ghost
Copy link

ghost commented Jun 25, 2020

@aeiras I will read that at Saturday, because I'm working now, but, I pretend to redo some others images to svg.
It's a little weird for me contributing with graphics being a programmer hahaha

@ggam
Copy link
Contributor

ggam commented Jun 25, 2020 via email

@ghost
Copy link

ghost commented Jun 26, 2020

@ggam sorry for delay to answer. Could you say me where that images are located? At saturday, I will evaluate and estimate the time to do it.

@ggam
Copy link
Contributor

ggam commented Jun 26, 2020 via email

@kwsutter
Copy link
Contributor Author

This Issue is closed. Maybe it would be better to continue the Tutorial image request in the Tutorial repo? Thanks! @ggam @cpusam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants