Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a script to build jakartaee docs locally #27

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

Ndacyayisenga-droid
Copy link
Contributor

cc @kito99


- Navigates back to the `jakartaee-documentation` repository after building the UI.

3. Copy the Antora Playbook:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps 3 and 4 should only happen if local-antora-playbook.yml doesn't already exist. Otherwise the script may overwrite local changes.


1. Build `jakartaee-documentation-ui:`

- Navigates to the `jakartaee-documentation-ui` repository and builds the UI using gulp bundle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: gulp bundle

`jakartaee-documentation` repositories are cloned in the same parent
directory.

3. Make the script executable by running.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the script was already executable.

4. Run the script from the terminal or command line:

```bash
./build-and-run.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./build-jakartaee-docs.sh

Copy link
Contributor

@kito99 kito99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more I think about it, the more I think this really does belong in the jakartaee-documentation-ui repo. @BalusC wdyt?

# Step 1: Navigate to the jakartaee-documentation-ui repository and build it
echo "Navigating to jakartaee-documentation-ui and building..."
cd ../jakartaee-documentation-ui || { echo "Error: jakartaee-documentation-ui directory not found."; exit 1; }
gulp bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add nvm use here. Otherwise if they have a different version of Node setup, it may fail (it did for me).

@kito99 kito99 merged commit 652d6a7 into jakartaee:main Oct 18, 2024
3 checks passed
@kito99
Copy link
Contributor

kito99 commented Oct 18, 2024

@Ndacyayisenga-droid , Bauke made good points about this staying in this repo, so let's leave it here and perhaps update it to work for the jakartaee-tutorial and cargotracker repos (only if they exist locally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants