Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/music command #1534

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor/music command #1534

wants to merge 4 commits into from

Commits on Apr 1, 2024

  1. Refactor music command: Decompose complex method and conditions,Remov… 

    …e a complex method and decomposed a complex condition in the music command to improve code readability and maintainability.
    @dhruvi1404
    dhruvi1404 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    8d32edc View commit details
    Browse the repository at this point in the history

  2. Refactor : Move a method from NowPlayingHandler to the Bot class to r… 

    …educe feature envy and improve encapsulation. The method was more dependent on Bot's functionality, making it more appropriate to be housed within the Bot class.
    @dhruvi1404
    dhruvi1404 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    7d2425b View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Refactor : Pull-up variable/method: 

    Location: JMusicBot class
Rationale: Move the RECOMMENDED_PERMS variable to a superclass where it can be shared among multiple classes.
    @dhruvi1404
    dhruvi1404 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    138b84b View commit details
    Browse the repository at this point in the history

  2. Refactor : remove broken hierarchy code smell

    @dhruvi1404
    dhruvi1404 committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8351c4a View commit details
    Browse the repository at this point in the history