Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logs by ./exe.sh is not clear #6

Open
jacobkim9881 opened this issue Sep 15, 2022 · 0 comments
Open

The logs by ./exe.sh is not clear #6

jacobkim9881 opened this issue Sep 15, 2022 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@jacobkim9881
Copy link
Owner

jacobkim9881 commented Sep 15, 2022

Brief

Script started.
local_obj.json will be translated into other language version local_obj.json.
spawn node ./src/index.js 0 local_obj.json
0 :  /usr/local/bin/node
1 :  /Users/mac/localization-manager/src/index.js
2 :  0
3 :  local_obj.json
Tag name is undefined at:  []
Target language:  af
Tag name is undefined at:  undefined
file is written

Above it shows progress of translating by executing ./exe.sh local_obj.json. As executing the command target json file is copied and written as new translated json file without any error. And while waiting for finishing execution the user reads logs above, which contains unnecessary information. For example,

spawn node ./src/index.js 0 local_obj.json // this is inner command of the execution command.
1 :  /Users/mac/localization-manager/src/index.js // this is location of execution script at line 12 at ./src/index.js
Tag name is undefined at:  [] // this is console message while unit testing at line 61 at ./test/test-utils.js

Such information is needed when debugging but does not need while users executing. Rather users needs such information like Target json file the user puts, The progress how many translated json files are created. I want other contributors ideas which logs are not needed and which information is needed. After pondering this issue for a while, asking pull requesting will be proceed.

Problem

Some logs while executing command ./exe.sh local_obj.json looks not needed. Some information are omitted for users.

Objective

Suggestions and advices about helpful information to users while executing the repo.

Required environments

  1. You have linux like OS or apple OS.
  2. You have node.js within your OS.

How to check logs while executing

  1. Download this repository.
  2. Install node packages this repository needs at the repository directory.
  3. Execute this repository to check logs by command ./exe.sh local_obj.json
  4. Check the logs on the terminal(you can cancel execution to put ctrl + c or ctrl + z).
  5. Notice how the repository changes ./local_obj.json into ./_locales/*.json.

Wise advices

  1. Advices about logs which are not needed and should be deleted.
  2. About information that users need while executing the repo.
  3. Any advices that helps contribute this repo will be helpful.
@jacobkim9881 jacobkim9881 added help wanted Extra attention is needed question Further information is requested labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant